Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity
playwright/packages/playwright-core
History
Max Schmitt 8bc26a2b44
chore: wait for downloads getting removed on context.close() (#23500) 
Before there was a race, that we ran into this code:


9cd49d5dd5/packages/playwright-core/src/server/browserContext.ts (L236-L237)

and then into this code:


9cd49d5dd5/packages/playwright-core/src/server/browserContext.ts (L429-L431)

which had the side effect, that the first call did not wait. Then
immediately clears the downloads Set and then the second call is a NOOP.
This ends up that the the removal of the downloads can happen after the
context is closed, hence the test is flaky.

Relates to https://github.com/microsoft/playwright/pull/6151 where it
got introduced. So something for @yury-s.

Fixes https://github.com/microsoft/playwright/issues/22525
2023-06-06 20:38:36 +02:00
..
bin chore(docker): remove experimental docker integration (#20676) 2023-02-06 10:50:45 -08:00
bundles chore: make trace viewer work over http (#23531) 2023-06-05 16:30:30 -07:00
src chore: wait for downloads getting removed on context.close() (#23500) 2023-06-06 20:38:36 +02:00
types chore: render plain class links in types (#23508) 2023-06-05 18:50:44 +02:00
.eslintrc.js lint: prevent object string concatenation (#23172) 2023-05-19 15:17:43 -07:00
.npmignore chore: remove experimental dockerfile.remote (#20790) 2023-02-09 12:18:02 -08:00
browsers.json feat(webkit): roll to r1860 (#23494) 2023-06-05 09:51:39 -07:00
cli.js chore: fix playwright-core cli (#23203) 2023-05-22 12:37:08 -07:00
index.d.ts chore: migrate to monorepo (#9421) 2021-10-11 16:52:17 +02:00
index.js chore: sunset Node.js 12 (#16512) 2022-08-15 18:10:04 +02:00
index.mjs fix: export request from index.jsm (#13158) 2022-03-30 09:35:47 -07:00
package.json chore: upgrade @types/node to 16.x (#23429) 2023-06-02 10:04:41 +02:00
README.md chore: drop dependency on playwright-core in all our packages (#2318) 2020-05-21 13:18:15 -07:00
ThirdPartyNotices.txt chore: make trace viewer work over http (#23531) 2023-06-05 16:30:30 -07:00

README.md

playwright-core

This package contains the no-browser flavor of Playwright.