Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity
playwright/tests/page
History
Dmitry Gozman af40eae13e chore: make noWaitAfter a default 
This changes the last actions, namely `click` and `press`, to not wait
for the ongoing navigations after the action.

Maintaining this behavior becomes tricky, because browsers move away from
guaranteed synchronous navigations to optimized performance. See #34377
for more details.

This is technically a breaking change. Most of the time, this should
not be noticeable, because the next action will auto-wait the navigation
and for any required conditions anyway. However, there are some patterns
revealed by our tests that are affected:
- Calling `goBack/goForward` immediately after an action. This pattern
  requires `expect(page).toHaveURL()` or a similar check inbetween.
- Listening for network events during the action, and immediately
  asserting after the action. This pattern requires `waitForRequest()`
  or a similar promise-based waiter as recommended in best practices.

We maintain the opt-out `env.PLAYWRIGHT_WAIT_AFTER_CLICK` that reverts
to the old behavior for now.

Additionally, previous opt-out option `env.PLAYWRIGHT_SKIP_NAVIGATION_CHECK`
has been removed, because there have been just a single issue with it,
that was immediately addressed in a patch release.
2025-02-04 15:17:43 +00:00
..
elementhandle-screenshot.spec.ts-snapshots Add canonical screenshots for firefox with webdriver bidi for screenshot element tests (#34289) 2025-01-24 15:15:24 -08:00
expect-matcher-result.spec.ts-snapshots Add canonical screenshots for firefox with webdriver bidi for screenshot element tests (#34289) 2025-01-24 15:15:24 -08:00
locator-misc-2.spec.ts-snapshots Add canonical screenshots for firefox with webdriver bidi for screenshot element tests (#34289) 2025-01-24 15:15:24 -08:00
page-add-locator-handler.spec.ts-snapshots Add canonical screenshots for firefox with webdriver bidi for screenshot element tests (#34289) 2025-01-24 15:15:24 -08:00
page-request-fulfill.spec.ts-snapshots test: roll to folio@0.4.0-alpha28 (#6918) 2021-06-04 20:54:58 -07:00
page-screenshot.spec.ts-snapshots feat(webkit): roll to r2092 (#33078) 2024-10-14 22:21:49 +02:00
elementhandle-bounding-box.spec.ts test: remove some fixmes (#32953) 2024-10-04 08:22:27 -07:00
elementhandle-click.spec.ts test: rename #smoke to @smoke as test tags (#12652) 2022-03-10 19:42:52 +01:00
elementhandle-content-frame.spec.ts test: cleanup bad usages of pageTest (#6430) 2021-05-06 07:08:22 -07:00
elementhandle-convenience.spec.ts feat: increase length of printed html tags (#31105) 2024-05-31 10:45:56 -07:00
elementhandle-eval-on-selector.spec.ts chore: unify target closed errors (#27540) 2023-10-12 11:05:34 -07:00
elementhandle-misc.spec.ts fix: allow disposing ElementHandles multiple times (#29953) 2024-03-15 16:26:56 +01:00
elementhandle-owner-frame.spec.ts chore: roll Electron to 16.2.8 (#16017) 2022-07-28 15:41:32 +02:00
elementhandle-press.spec.ts feat(webkit): roll to r1616 (#12541) 2022-03-06 12:22:47 +01:00
elementhandle-query-selector.spec.ts chore: roll Electron to 16.2.8 (#16017) 2022-07-28 15:41:32 +02:00
elementhandle-screenshot.spec.ts feat(webkit): roll to r2108 (#33710) 2024-11-21 14:42:21 -08:00
elementhandle-scroll-into-view.spec.ts test: unflake various tests (#32014) 2024-08-05 08:29:13 -07:00
elementhandle-select-text.spec.ts chore: introduce clock test mode (#31110) 2024-05-31 14:44:26 -07:00
elementhandle-type.spec.ts feat(webkit): roll to r1616 (#12541) 2022-03-06 12:22:47 +01:00
elementhandle-wait-for-element-state.spec.ts test: remove some fixmes (#32953) 2024-10-04 08:22:27 -07:00
eval-on-selector-all.spec.ts chore: enable object-curly-spacing in ESLint (#9168) 2021-09-27 18:58:08 +02:00
eval-on-selector.spec.ts chore: unify target closed errors (#27540) 2023-10-12 11:05:34 -07:00
expect-boolean.spec.ts chore: better error message when CSS selector fails to parse (#34331) 2025-01-15 11:34:51 -08:00
expect-matcher-result.spec.ts feat(toBeChecked): allow indeterminate expectation (#34269) 2025-01-09 18:18:15 -08:00
expect-misc.spec.ts feat: toHaveURL predicate matcher (#34413) 2025-01-24 06:00:17 -08:00
expect-timeout.spec.ts fix(expect): account for timeout during the first locator handler check (#32095) 2024-08-12 01:57:15 -07:00
expect-to-have-text.spec.ts fix(expect): throw better received error when no element was found (#29890) 2024-04-10 10:01:19 +02:00
expect-to-have-value.spec.ts test: migrate some expect() tests to be more readable (#16394) 2022-08-10 15:10:25 -07:00
frame-evaluate.spec.ts chore(lint): Ensure EOL newlines (#34117) 2024-12-20 09:17:09 -08:00
frame-frame-element.spec.ts test: some tests for expected API behavior (#32495) 2024-09-06 13:13:44 -07:00
frame-goto.spec.ts test: mark a few tests as fixme (#32985) 2024-10-07 02:58:03 -07:00
frame-hierarchy.spec.ts test: update stale test expectations (#20423) 2023-01-27 21:52:34 -08:00
interception.spec.ts fix(chromium): disable PlzDedicatedWorker again (#33110) 2024-10-15 02:13:19 -07:00
jshandle-as-element.spec.ts test: rename #smoke to @smoke as test tags (#12652) 2022-03-10 19:42:52 +01:00
jshandle-evaluate.spec.ts test: rename #smoke to @smoke as test tags (#12652) 2022-03-10 19:42:52 +01:00
jshandle-json-value.spec.ts chore: serialize circular objects (#14045) 2022-05-09 18:51:53 -07:00
jshandle-properties.spec.ts test: rename #smoke to @smoke as test tags (#12652) 2022-03-10 19:42:52 +01:00
jshandle-to-string.spec.ts chore: remove same-site expectations for old browsers (#32334) 2024-08-26 18:41:58 -07:00
locator-click.spec.ts feat(firefox): roll to r1396 (#22327) 2023-04-11 08:49:44 -07:00
locator-convenience.spec.ts fix: isEditable/toBeEditable throw for elements that cannot be editable/readonly (#33713) 2024-11-22 03:40:43 -08:00
locator-element-handle.spec.ts test: rename #smoke to @smoke as test tags (#12652) 2022-03-10 19:42:52 +01:00
locator-evaluate.spec.ts test: rename #smoke to @smoke as test tags (#12652) 2022-03-10 19:42:52 +01:00
locator-frame.spec.ts chore: use contentFrame() as a canonical locator representation (#32697) 2024-09-18 20:15:01 -07:00
locator-highlight.spec.ts chore: allow editing aria template in recorder (tests) (#33522) 2024-11-08 17:18:51 -08:00
locator-is-visible.spec.ts Fix various typos (Fixes #27396) (#27391) 2023-10-04 19:56:42 -07:00
locator-list.spec.ts chore: withdraw locator.enumerate (#19484) 2022-12-15 10:13:56 -08:00
locator-misc-1.spec.ts test: fix/fixme/update a few tests (#33006) 2024-10-08 03:59:35 -07:00
locator-misc-2.spec.ts chore(lint): Ensure EOL newlines (#34117) 2024-12-20 09:17:09 -08:00
locator-query.spec.ts chore: use contentFrame() as a canonical locator representation (#32697) 2024-09-18 20:15:01 -07:00
matchers.misc.spec.ts fix(expect): throw better received error when no element was found (#29890) 2024-04-10 10:01:19 +02:00
network-post-data.spec.ts chore: enable no-floating-promises ESLint rule for tests (#23376) 2023-06-02 21:59:12 +02:00
page-accessibility.spec.ts chore: remove macOS <=12 checks (#33591) 2024-11-13 17:21:21 -08:00
page-add-init-script.spec.ts Revert feat(addInitScript): support cjs modules (#32364) 2024-08-28 15:39:48 -07:00
page-add-locator-handler.spec.ts feat(locator handler): perform checkpoit during locator.waitFor (#32683) 2024-09-18 09:34:06 -07:00
page-add-script-tag.spec.ts chore: enable object-curly-spacing in ESLint (#9168) 2021-09-27 18:58:08 +02:00
page-add-style-tag.spec.ts test: rename #smoke to @smoke as test tags (#12652) 2022-03-10 19:42:52 +01:00
page-aria-snapshot.spec.ts fix(aria): disregard text area textContent (#34544) 2025-01-29 16:06:07 -08:00
page-autowaiting-basic.spec.ts chore: make noWaitAfter a default 2025-02-04 15:17:43 +00:00
page-autowaiting-no-hang.spec.ts feat: wait for pending navigation to resolve before many actions (#32899) 2024-10-04 07:25:18 -07:00
page-basic.spec.ts feat(firefox): roll to r1452 (#31068) 2024-05-29 08:28:26 -07:00
page-check.spec.ts chore: revert inadvertent test change (#34459) 2025-01-23 12:12:53 -08:00
page-click-during-navigation.spec.ts test: improve click-during-navigation (#11252) 2022-01-07 12:12:24 -08:00
page-click-react.spec.ts test: remove tests that we are not going to ever fix (#32962) 2024-10-04 08:22:36 -07:00
page-click-scroll.spec.ts test: update webview2 skipme's (#32984) 2024-10-07 11:08:07 +02:00
page-click-timeout-1.spec.ts chore: refactor actionability check to go through node-side retry (#28982) 2024-01-16 19:11:41 -08:00
page-click-timeout-2.spec.ts chore: refactor actionability check to go through node-side retry (#28982) 2024-01-16 19:11:41 -08:00
page-click-timeout-3.spec.ts feat(input): perform hit target check during input (#9546) 2021-11-05 17:31:28 -07:00
page-click-timeout-4.spec.ts chore: introduce clock test mode (#31110) 2024-05-31 14:44:26 -07:00
page-click.spec.ts fix(click): better compensate for integer click coordinates in firefox (#33467) 2024-11-07 00:01:00 -08:00
page-close.spec.ts chore: introduce clock test mode (#31110) 2024-05-31 14:44:26 -07:00
page-dialog.spec.ts chore: introduce clock test mode (#31110) 2024-05-31 14:44:26 -07:00
page-dispatchevent.spec.ts chore: introduce clock test mode (#31110) 2024-05-31 14:44:26 -07:00
page-drag.spec.ts test: update some test conditions (#31336) 2024-06-17 10:20:57 -07:00
page-emulate-media.spec.ts feat(firefox): roll to r1456 (#31375) 2024-06-19 19:03:58 +02:00
page-evaluate-handle.spec.ts chore: serialize circular objects (#14045) 2022-05-09 18:51:53 -07:00
page-evaluate-no-stall.spec.ts chore: enable no-floating-promises ESLint rule for tests (#23376) 2023-06-02 21:59:12 +02:00
page-evaluate.spec.ts fix: throw an error when object reference chain is to long to serialize (#34008) 2024-12-13 13:38:26 -08:00
page-event-console.spec.ts chore: introduce clock test mode (#31110) 2024-05-31 14:44:26 -07:00
page-event-load.spec.ts fix(events): avoid firing lifecycle events twice (#16055) 2022-07-29 12:44:04 -07:00
page-event-network.spec.ts fix: interrupt request.allHeaders()/response() on page.close() (#27695) 2023-10-23 12:45:35 -07:00
page-event-pageerror.spec.ts chore: introduce clock test mode (#31110) 2024-05-31 14:44:26 -07:00
page-event-popup.spec.ts fix(route): make sure Route.fetch works for popup main request (#26590) 2023-08-21 16:48:51 -07:00
page-event-request.spec.ts fix(firefox): disable fetch keep-alive for now before a proper fix (#34530) 2025-01-29 09:50:32 +00:00
page-expose-function.spec.ts chore: improve error message when Array.toJSON misbehaves (#32508) 2024-09-10 04:14:24 -07:00
page-fill.spec.ts fix: isEditable/toBeEditable throw for elements that cannot be editable/readonly (#33713) 2024-11-22 03:40:43 -08:00
page-focus.spec.ts chore: download and launch chromium-headless-shell for headless chromium (#33454) 2024-11-13 02:52:28 -08:00
page-goto.spec.ts feat(webkit): roll to r2090 (#33050) 2024-10-11 00:08:03 +02:00
page-history.spec.ts chore: make noWaitAfter a default 2025-02-04 15:17:43 +00:00
page-keyboard.spec.ts test: do not check deprecated KeyboardEvent.keyCode property (#34472) 2025-01-24 15:09:39 -08:00
page-leaks.spec.ts chore: fix cross browser leak tests (#32843) 2024-09-26 19:33:07 -07:00
page-listeners.spec.ts feat(events): allow waiting for removeAllListeners (#31941) 2024-08-05 21:14:35 -07:00
page-mouse.spec.ts chore(lint): Ensure EOL newlines (#34117) 2024-12-20 09:17:09 -08:00
page-navigation.spec.ts chore: enable no-floating-promises ESLint rule for tests (#23376) 2023-06-02 21:59:12 +02:00
page-network-idle.spec.ts chore: enable no-floating-promises ESLint rule for tests (#23376) 2023-06-02 21:59:12 +02:00
page-network-request.spec.ts chore: make noWaitAfter a default 2025-02-04 15:17:43 +00:00
page-network-response.spec.ts test: unflake two tests (#32879) 2024-09-30 07:49:18 -07:00
page-network-sizes.spec.ts chore: roll Electron to 16.2.8 (#16017) 2022-07-28 15:41:32 +02:00
page-request-continue.spec.ts test: fix/fixme/update a few tests (#33006) 2024-10-08 03:59:35 -07:00
page-request-fallback.spec.ts chore: enable no-floating-promises ESLint rule for tests (#23376) 2023-06-02 21:59:12 +02:00
page-request-fulfill.spec.ts chore(lint): Ensure EOL newlines (#34117) 2024-12-20 09:17:09 -08:00
page-request-gc.spec.ts chore: address api review for page.forceGarbageCollection (#32824) 2024-09-26 05:08:33 -07:00
page-request-intercept.spec.ts fix: do not send favicon request to network when interception is on (#33639) 2024-11-18 11:01:39 -08:00
page-route.spec.ts chore(bidi): Fix handling of cookie headers in network.continueRequest (#34277) 2025-01-10 11:06:26 -08:00
page-screenshot.spec.ts feat(webkit): roll to r2108 (#33710) 2024-11-21 14:42:21 -08:00
page-select-option.spec.ts chore: introduce clock test mode (#31110) 2024-05-31 14:44:26 -07:00
page-set-content.spec.ts test: reenable "return empty content there is no iframe src" in cr and ff (#34241) 2025-01-07 11:49:14 -08:00
page-set-extra-http-headers.spec.ts test: rename #smoke to @smoke as test tags (#12652) 2022-03-10 19:42:52 +01:00
page-set-input-files.spec.ts chore: make noWaitAfter a default 2025-02-04 15:17:43 +00:00
page-strict.spec.ts fix(selector generator): escape all tag names in css selectors (#26659) 2023-08-23 12:32:08 -07:00
page-wait-for-function.spec.ts chore: introduce clock test mode (#31110) 2024-05-31 14:44:26 -07:00
page-wait-for-load-state.spec.ts chore: enable no-floating-promises ESLint rule for tests (#23376) 2023-06-02 21:59:12 +02:00
page-wait-for-navigation.spec.ts chore: introduce clock test mode (#31110) 2024-05-31 14:44:26 -07:00
page-wait-for-request.spec.ts chore: introduce clock test mode (#31110) 2024-05-31 14:44:26 -07:00
page-wait-for-response.spec.ts chore: introduce clock test mode (#31110) 2024-05-31 14:44:26 -07:00
page-wait-for-selector-1.spec.ts chore: introduce clock test mode (#31110) 2024-05-31 14:44:26 -07:00
page-wait-for-selector-2.spec.ts fix: throw when element handle is detached while waiting for selector (#32961) 2024-10-04 08:23:25 -07:00
page-wait-for-url.spec.ts test: update tests for waituntil:commit (#20042) 2023-01-11 10:16:51 -08:00
pageTest.ts chore: allow editing aria template in recorder (tests) (#33522) 2024-11-08 17:18:51 -08:00
pageTestApi.ts test: update 'should work for canvas' test expectation (#33685) 2024-11-20 17:13:07 +01:00
queryselector.spec.ts test: rename #smoke to @smoke as test tags (#12652) 2022-03-10 19:42:52 +01:00
retarget.spec.ts fix(retarget): do not unconditionally retarget to enclosing label (#34229) 2025-01-07 11:15:00 -08:00
selectors-css.spec.ts test: remove some fixmes (#32953) 2024-10-04 08:22:27 -07:00
selectors-frame.spec.ts fix: throw when element handle is detached while waiting for selector (#32961) 2024-10-04 08:23:25 -07:00
selectors-get-by.spec.ts fix(locators): escape >> inside a regular expression (#23631) 2023-06-12 10:34:37 -07:00
selectors-misc.spec.ts chore: better error message when CSS selector fails to parse (#34331) 2025-01-15 11:34:51 -08:00
selectors-react.spec.ts chore(lint): Ensure EOL newlines (#34117) 2024-12-20 09:17:09 -08:00
selectors-register.spec.ts chore: enable no-floating-promises ESLint rule for tests (#23376) 2023-06-02 21:59:12 +02:00
selectors-role.spec.ts Revert "chore(role): cache element list by role (#29130)" (#29765) 2024-03-01 09:37:28 -08:00
selectors-text.spec.ts fix: text-is() should ignore comments (#33980) 2024-12-12 17:49:31 -08:00
selectors-vue.spec.ts chore(lint): Ensure EOL newlines (#34117) 2024-12-20 09:17:09 -08:00
to-match-aria-snapshot.spec.ts chore: include child nodes when parsing snapshot (#34318) 2025-01-13 18:25:41 -08:00
wheel.spec.ts chore: remove same-site expectations for old browsers (#32334) 2024-08-26 18:41:58 -07:00
workers.spec.ts fix(chromium): disable PlzDedicatedWorker again (#33110) 2024-10-15 02:13:19 -07:00