playwright/packages/trace-viewer
Simon Knott daca1681c0
refactor(ui): in splitview component, move sidebar and main from children into named properties (#31925)
Pulled out from https://github.com/microsoft/playwright/pull/31900

I stumbled over `React.Children`, because it's the first time I saw that
used. https://react.dev/reference/react/Children lists `React.Children`
it as "Legacy" and mentions it's uncommon. Also, the fact that SplitView
only displays its first two children, and all others are silently
discarded, can be a surprise to some.

By separating things out into `sidebar` and `main`, not only do we give
the two elements names (otherwise one needs to remember that sidebar is
always the first child), but we also prevent any "third children" from
being dropped.
2024-07-31 12:48:46 +02:00
..
public chore: use SVG icons for web apps (#26564) 2023-08-21 18:33:02 +02:00
src refactor(ui): in splitview component, move sidebar and main from children into named properties (#31925) 2024-07-31 12:48:46 +02:00
.gitignore fix(debug): do not pause on internal calls, update ct docs (#14018) 2022-05-07 19:56:25 -07:00
bundle.ts chore: address deprecated Vite warnings (#31618) 2024-07-10 22:32:08 +02:00
embedded.html feature(trace-viewer): embedded mode support PoC (#30885) 2024-06-28 10:36:11 -07:00
index.html chore: use SVG icons for web apps (#26564) 2023-08-21 18:33:02 +02:00
package.json chore: address deprecated Vite warnings (#31618) 2024-07-10 22:32:08 +02:00
snapshot.html fix(trace-viewer): fix snapshot.html (#31033) 2024-05-28 13:14:22 -07:00
tsconfig.json chore: make @playwright/test depend on playwright (#26946) 2023-09-08 14:23:35 -07:00
tsconfig.node.json chore: address deprecated Vite warnings (#31618) 2024-07-10 22:32:08 +02:00
uiMode.html chore: use SVG icons for web apps (#26564) 2023-08-21 18:33:02 +02:00
vite.config.ts chore: address deprecated Vite warnings (#31618) 2024-07-10 22:32:08 +02:00
vite.sw.config.ts chore: address deprecated Vite warnings (#31618) 2024-07-10 22:32:08 +02:00