playwright/utils/build
Patrick Shaw 6e78dcb7dc
fix: Allow portable bash paths for systems including NixOS (#23889)
Although very common, bash is not guaranteed to be located at
`/bin/bash`. NixOS is an example of this.

More commonly, `/bin/bash` can be quite out of date. An example of this
is MacOS's version of `bash`. This realistically won't affect Playwright
but it's worth noting. You can technically update MacOS's system version
of bash but you need elevated permissions to do so.

By using `/usr/bin/env bash` instead of `/bin/bash` we can execute
Playwright's bash scripts in like NixOS and generally improve the
selection behaviour for bash in other systems too.

Some discussion of why it's worth favouring `/usr/bin/env bash` over
`/bin/bash`:
- Discusses `/bin/bash` missing in NixOS:
https://discourse.nixos.org/t/add-bin-bash-to-avoid-unnecessary-pain/5673
- Some general commentary on why `/usr/bin/env bash` is favoured:
https://askubuntu.com/a/1402721
- Points out how old bash is in MacOS:
https://itnext.io/upgrading-bash-on-macos-7138bd1066ba

Improves situation at #5501
2023-07-03 06:27:06 -07:00
..
.gitignore feat(cli): build driver and upload to cdn (#4841) 2021-01-05 14:04:47 -08:00
build-playwright-driver.sh fix: Allow portable bash paths for systems including NixOS (#23889) 2023-07-03 06:27:06 -07:00
build.js fix(tracing): do not double-zip entries in remote mode (#21579) 2023-03-10 14:54:32 -08:00
clean.js feat(ct): support Vue2 (#14600) 2022-06-02 17:37:43 -07:00
deploy-trace-viewer.sh fix: Allow portable bash paths for systems including NixOS (#23889) 2023-07-03 06:27:06 -07:00
run-driver-posix.sh fix(driver): PLAYWRIGHT_NODEJS_PATH test in sh (#16554) 2022-08-15 12:24:52 -07:00
run-driver-win.cmd fix: expect unquoted npde.exe path (#21307) 2023-03-01 09:16:23 -08:00
update-playwright-driver-version.mjs devops: auto roll Node.js version of driver follow-up 2022-07-11 15:54:46 +02:00
update_canary_version.js chore: unify workspace helper scripts (#11925) 2022-02-08 10:35:00 -08:00
upload-playwright-driver.sh fix: Allow portable bash paths for systems including NixOS (#23889) 2023-07-03 06:27:06 -07:00