Textual snapshot diffs were previously broken in the HTML Report. The strikethrough'd text extended beyond the intended region. HTML Report Before: <img width="693" alt="Screen Shot 2021-12-27 at 4 43 35 PM" src="https://user-images.githubusercontent.com/11915034/147518750-a60f9002-6eed-48a1-a412-20fabd076fa6.png"> HTML Report After: <img width="206" alt="Screen Shot 2021-12-27 at 4 48 37 PM" src="https://user-images.githubusercontent.com/11915034/147518762-19a4c8f9-ccc3-4a3c-a962-5a42edc6fc5d.png"> This now matches what's expected and shown in the terminal (which has always been correct): <img width="1384" alt="Screen Shot 2021-12-27 at 4 36 29 PM" src="https://user-images.githubusercontent.com/11915034/147518799-f538259e-5a45-4d6f-916c-a12ccb620c5b.png"> NB: This MR is a workaround, but not a root cause fix. It works, but I never fully got to the root cause so a bug upstream may be required. It's unclear whether it's (1) in [`colors`](https://www.npmjs.com/package/colors), (2) in [`ansi-to-html`](https://www.npmjs.com/package/ansi-to-html), or (3) Playwright's use of the two. Since the terminal output is correct, I suspect it is in `ansi-to-html`. For example: ```js const colors = require("colors"); const Convert = require('ansi-to-html'); const convert = new Convert(); // original (strike incorrectly wraps everything in the HTML) console.log(convert.toHtml(colors.strikethrough("crossed out") + ' ' + colors.red("red"))) // prints: <strike>crossed out <span style="color:#A00">red<span style="color:#FFF"></span></span></strike> // workaround console.log(convert.toHtml(colors.reset(colors.strikethrough("crossed out")) + ' ' + colors.red("red"))) // prints: <strike>crossed out</strike> <span style="color:#A00">red<span style="color:#FFF"></span></span> ``` Fixes #11116
240 lines
8.8 KiB
TypeScript
240 lines
8.8 KiB
TypeScript
/**
|
|
* Copyright 2017 Google Inc. All rights reserved.
|
|
* Modifications copyright (c) Microsoft Corporation.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
/* eslint-disable no-console */
|
|
import colors from 'colors/safe';
|
|
import fs from 'fs';
|
|
import path from 'path';
|
|
import jpeg from 'jpeg-js';
|
|
import pixelmatch from 'pixelmatch';
|
|
import { diff_match_patch, DIFF_INSERT, DIFF_DELETE, DIFF_EQUAL } from '../third_party/diff_match_patch';
|
|
import { TestInfoImpl, UpdateSnapshots } from '../types';
|
|
import { addSuffixToFilePath } from '../util';
|
|
import BlinkDiff from '../third_party/blink-diff';
|
|
import PNGImage from '../third_party/png-js';
|
|
|
|
// Note: we require the pngjs version of pixelmatch to avoid version mismatches.
|
|
const { PNG } = require(require.resolve('pngjs', { paths: [require.resolve('pixelmatch')] })) as typeof import('pngjs');
|
|
|
|
const extensionToMimeType: { [key: string]: string } = {
|
|
'dat': 'application/octet-string',
|
|
'jpeg': 'image/jpeg',
|
|
'jpg': 'image/jpeg',
|
|
'png': 'image/png',
|
|
'txt': 'text/plain',
|
|
};
|
|
|
|
type Comparator = (actualBuffer: Buffer | string, expectedBuffer: Buffer, mimeType: string, options?: any) => { diff?: Buffer; errorMessage?: string; } | null;
|
|
const GoldenComparators: { [key: string]: Comparator } = {
|
|
'application/octet-string': compareBuffersOrStrings,
|
|
'image/png': compareImages,
|
|
'image/jpeg': compareImages,
|
|
'text/plain': compareText,
|
|
};
|
|
|
|
function compareBuffersOrStrings(actualBuffer: Buffer | string, expectedBuffer: Buffer, mimeType: string): { diff?: Buffer; errorMessage?: string; } | null {
|
|
if (typeof actualBuffer === 'string')
|
|
return compareText(actualBuffer, expectedBuffer);
|
|
if (!actualBuffer || !(actualBuffer instanceof Buffer))
|
|
return { errorMessage: 'Actual result should be a Buffer or a string.' };
|
|
if (Buffer.compare(actualBuffer, expectedBuffer))
|
|
return { errorMessage: 'Buffers differ' };
|
|
return null;
|
|
}
|
|
|
|
function compareImages(actualBuffer: Buffer | string, expectedBuffer: Buffer, mimeType: string, options = {}): { diff?: Buffer; errorMessage?: string; } | null {
|
|
if (!actualBuffer || !(actualBuffer instanceof Buffer))
|
|
return { errorMessage: 'Actual result should be a Buffer.' };
|
|
|
|
const actual = mimeType === 'image/png' ? PNG.sync.read(actualBuffer) : jpeg.decode(actualBuffer);
|
|
const expected = mimeType === 'image/png' ? PNG.sync.read(expectedBuffer) : jpeg.decode(expectedBuffer);
|
|
if (expected.width !== actual.width || expected.height !== actual.height) {
|
|
return {
|
|
errorMessage: `Sizes differ; expected image ${expected.width}px X ${expected.height}px, but got ${actual.width}px X ${actual.height}px. `
|
|
};
|
|
}
|
|
const diff = new PNG({ width: expected.width, height: expected.height });
|
|
const thresholdOptions = { threshold: 0.2, ...options };
|
|
if (process.env.PW_USE_BLINK_DIFF && mimeType === 'image/png') {
|
|
const diff = new BlinkDiff({
|
|
imageA: new PNGImage(expected as any),
|
|
imageB: new PNGImage(actual as any),
|
|
});
|
|
const result = diff.runSync();
|
|
return result.code !== BlinkDiff.RESULT_IDENTICAL ? { diff: PNG.sync.write(diff._imageOutput.getImage()) } : null;
|
|
}
|
|
const count = pixelmatch(expected.data, actual.data, diff.data, expected.width, expected.height, thresholdOptions);
|
|
return count > 0 ? { diff: PNG.sync.write(diff) } : null;
|
|
}
|
|
|
|
function compareText(actual: Buffer | string, expectedBuffer: Buffer): { diff?: Buffer; errorMessage?: string; diffExtension?: string; } | null {
|
|
if (typeof actual !== 'string')
|
|
return { errorMessage: 'Actual result should be a string' };
|
|
const expected = expectedBuffer.toString('utf-8');
|
|
if (expected === actual)
|
|
return null;
|
|
const dmp = new diff_match_patch();
|
|
const d = dmp.diff_main(expected, actual);
|
|
dmp.diff_cleanupSemantic(d);
|
|
return {
|
|
errorMessage: diff_prettyTerminal(d)
|
|
};
|
|
}
|
|
|
|
export function compare(
|
|
actual: Buffer | string,
|
|
pathSegments: string[],
|
|
testInfo: TestInfoImpl,
|
|
updateSnapshots: UpdateSnapshots,
|
|
withNegateComparison: boolean,
|
|
options?: { threshold?: number }
|
|
): { pass: boolean; message?: string; expectedPath?: string, actualPath?: string, diffPath?: string, mimeType?: string } {
|
|
const snapshotFile = testInfo.snapshotPath(...pathSegments);
|
|
const outputFile = testInfo.outputPath(...pathSegments);
|
|
const expectedPath = addSuffixToFilePath(outputFile, '-expected');
|
|
const actualPath = addSuffixToFilePath(outputFile, '-actual');
|
|
const diffPath = addSuffixToFilePath(outputFile, '-diff');
|
|
|
|
if (!fs.existsSync(snapshotFile)) {
|
|
const isWriteMissingMode = updateSnapshots === 'all' || updateSnapshots === 'missing';
|
|
const commonMissingSnapshotMessage = `${snapshotFile} is missing in snapshots`;
|
|
if (withNegateComparison) {
|
|
const message = `${commonMissingSnapshotMessage}${isWriteMissingMode ? ', matchers using ".not" won\'t write them automatically.' : '.'}`;
|
|
return { pass: true , message };
|
|
}
|
|
if (isWriteMissingMode) {
|
|
fs.mkdirSync(path.dirname(snapshotFile), { recursive: true });
|
|
fs.mkdirSync(path.dirname(actualPath), { recursive: true });
|
|
fs.writeFileSync(snapshotFile, actual);
|
|
fs.writeFileSync(actualPath, actual);
|
|
}
|
|
const message = `${commonMissingSnapshotMessage}${isWriteMissingMode ? ', writing actual.' : '.'}`;
|
|
if (updateSnapshots === 'all') {
|
|
console.log(message);
|
|
return { pass: true, message };
|
|
}
|
|
if (updateSnapshots === 'missing') {
|
|
if (testInfo.status === 'passed')
|
|
testInfo.status = 'failed';
|
|
if (!('error' in testInfo))
|
|
testInfo.error = { value: 'Error: ' + message };
|
|
else if (testInfo.error?.value)
|
|
testInfo.error.value += '\nError: ' + message;
|
|
return { pass: true, message };
|
|
}
|
|
return { pass: false, message };
|
|
}
|
|
|
|
const expected = fs.readFileSync(snapshotFile);
|
|
const extension = path.extname(snapshotFile).substring(1);
|
|
const mimeType = extensionToMimeType[extension] || 'application/octet-string';
|
|
const comparator = GoldenComparators[mimeType];
|
|
if (!comparator) {
|
|
return {
|
|
pass: false,
|
|
message: 'Failed to find comparator with type ' + mimeType + ': ' + snapshotFile,
|
|
};
|
|
}
|
|
|
|
const result = comparator(actual, expected, mimeType, options);
|
|
if (!result) {
|
|
if (withNegateComparison) {
|
|
const message = [
|
|
colors.red('Snapshot comparison failed:'),
|
|
'',
|
|
indent('Expected result should be different from the actual one.', ' '),
|
|
].join('\n');
|
|
return {
|
|
pass: true,
|
|
message,
|
|
};
|
|
}
|
|
|
|
return { pass: true };
|
|
}
|
|
|
|
if (withNegateComparison) {
|
|
return {
|
|
pass: false,
|
|
};
|
|
}
|
|
|
|
if (updateSnapshots === 'all') {
|
|
fs.mkdirSync(path.dirname(snapshotFile), { recursive: true });
|
|
fs.writeFileSync(snapshotFile, actual);
|
|
console.log(snapshotFile + ' does not match, writing actual.');
|
|
return {
|
|
pass: true,
|
|
message: snapshotFile + ' running with --update-snapshots, writing actual.'
|
|
};
|
|
}
|
|
|
|
fs.mkdirSync(path.dirname(expectedPath), { recursive: true });
|
|
fs.mkdirSync(path.dirname(actualPath), { recursive: true });
|
|
fs.writeFileSync(expectedPath, expected);
|
|
fs.writeFileSync(actualPath, actual);
|
|
if (result.diff)
|
|
fs.writeFileSync(diffPath, result.diff);
|
|
|
|
const output = [
|
|
colors.red(`Snapshot comparison failed:`),
|
|
];
|
|
if (result.errorMessage) {
|
|
output.push('');
|
|
output.push(indent(result.errorMessage, ' '));
|
|
}
|
|
output.push('');
|
|
output.push(`Expected: ${colors.yellow(expectedPath)}`);
|
|
output.push(`Received: ${colors.yellow(actualPath)}`);
|
|
if (result.diff)
|
|
output.push(` Diff: ${colors.yellow(diffPath)}`);
|
|
|
|
return {
|
|
pass: false,
|
|
message: output.join('\n'),
|
|
expectedPath,
|
|
actualPath,
|
|
diffPath: result.diff ? diffPath : undefined,
|
|
mimeType
|
|
};
|
|
}
|
|
|
|
function indent(lines: string, tab: string) {
|
|
return lines.replace(/^(?=.+$)/gm, tab);
|
|
}
|
|
|
|
function diff_prettyTerminal(diffs: diff_match_patch.Diff[]) {
|
|
const html = [];
|
|
for (let x = 0; x < diffs.length; x++) {
|
|
const op = diffs[x][0]; // Operation (insert, delete, equal)
|
|
const data = diffs[x][1]; // Text of change.
|
|
const text = data;
|
|
switch (op) {
|
|
case DIFF_INSERT:
|
|
html[x] = colors.green(text);
|
|
break;
|
|
case DIFF_DELETE:
|
|
html[x] = colors.reset(colors.strikethrough(colors.red(text)));
|
|
break;
|
|
case DIFF_EQUAL:
|
|
html[x] = text;
|
|
break;
|
|
}
|
|
}
|
|
return html.join('');
|
|
}
|