Filip/matrix-spec
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-spec synced 2026-03-23 03:34:08 +01:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Update 1250.feature

Browse source
This commit is contained in:
Srinjoy Sen Chowdhury 2024-08-13 22:43:38 +05:30 committed by GitHub
parent 3701f5dd65
commit 1a69a5142d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
changelogs/application_service/newsfragments/1250.feature
View file

@ -1,18 +1,21 @@
Issue 1250 fixed : allowed {as,hs}_token to be specified as {as,hs_token_path} instead in registration.yaml
Implementation Notes:
Token Handling Logic:
The application should first check if the *_token_path fields are set.
If they are, it should read the token from the specified file, strip any leading/trailing whitespace, and use it as the token.
If the *_token_path fields are not set, the application should fall back to using the *_token fields.
Security Considerations:
Ensure that the files containing the tokens have appropriate file permissions to prevent unauthorized access.
The application should handle potential errors such as file not found, permission denied, or empty token file gracefully.
Backward Compatibility:
This change is backward-compatible as it allows the use of either the direct token value (as_token/hs_token) or the path-based approach (as_token_path/hs_token_path).
Special Note : Also if we're allowing the use of either the direct token (as_token/hs_token) or the path-based token (as_token_path/hs_token_path), then neither
as_token nor hs_token should be marked as strictly required on their own in the required container.
as_token nor hs_token should be marked as strictly required on their own in the required container.