Fix extension check in check-newsfragments (#2402)

This was added in #1542, but has never worked correctly: it failed to set the exit code if an incorrectly-named newsfragment was found.
2026-06-20 22:57:48 +02:00 · 2026-06-17 09:19:41 +01:00 · 2026-06-17 09:19:41 +01:00 · 86396b46b8
parent c2d396fb98
commit 86396b46b8
6 changed files with 2 additions and 0 deletions
--- a/changelogs/application_service/newsfragments/2351.clarification
+++ b/changelogs/application_service/newsfragments/2351.clarification
--- a/changelogs/client_server/newsfragments/2351.clarification
+++ b/changelogs/client_server/newsfragments/2351.clarification
--- a/changelogs/internal/newsfragments/2402.clarification
+++ b/changelogs/internal/newsfragments/2402.clarification
@ -0,0 +1 @@
+Minor fixes to `check-newsfragments` CI script.
--- a/changelogs/room_versions/newsfragments/2351.clarification
+++ b/changelogs/room_versions/newsfragments/2351.clarification
--- a/changelogs/server_server/newsfragments/2351.clarification
+++ b/changelogs/server_server/newsfragments/2351.clarification
--- a/scripts/check-newsfragments
+++ b/scripts/check-newsfragments
@ -26,6 +26,7 @@ while read f; do
    # check that each changelog file has a known extension
    if ! [[ "$extension" == "new" || "$extension" == "feature" || "$extension" == "clarification" || "$extension" == "breaking" || "$extension" == "deprecation" ]]; then
        echo -e "\e[31mERROR: newsfragment $f does not have one of the required file extensions for a changelog entry: .new, .feature, .clarification, .breaking, .deprecation\e[39m" >&2
+        failed=1
    fi

    # check that there is nothing that looks like a newsfile outside one of the
				`@ -0,0 +1 @@`
				Minor fixes to `check-newsfragments` CI script.