Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore: remove redundant check in getElementAccessibleErrorMessage

Browse source
This commit is contained in:
Pengoose 2024-12-16 23:02:57 +09:00
parent a2b8124bfb
commit 00b41eb8d3
1 changed files with 8 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/playwright-core/src/server/injected/roleUtils.ts
View file

@ -475,9 +475,7 @@ export function getElementAccessibleErrorMessage(element: Element): string {
const isAriaInvalid = ariaInvalid !== null && ariaInvalid.toLowerCase() !== 'false'; const isAriaInvalid = ariaInvalid !== null && ariaInvalid.toLowerCase() !== 'false';
if (isAriaInvalid) { if (isAriaInvalid) {
const errorMessageId = element.getAttribute('aria-errormessage'); const errorMessageId = element.getAttribute('aria-errormessage');
if (errorMessageId) {
const errorMessages = getIdRefs(element, errorMessageId); const errorMessages = getIdRefs(element, errorMessageId);
if (errorMessages.length) {
const parts = errorMessages.map(errorMessage => asFlatString( const parts = errorMessages.map(errorMessage => asFlatString(
getTextAlternativeInternal(errorMessage, { getTextAlternativeInternal(errorMessage, {
visitedElements: new Set(), visitedElements: new Set(),
@ -486,8 +484,6 @@ export function getElementAccessibleErrorMessage(element: Element): string {
)); ));
accessibleErrorMessage = parts.join(' ').trim(); accessibleErrorMessage = parts.join(' ').trim();
} }
}
}
cache?.set(element, accessibleErrorMessage); cache?.set(element, accessibleErrorMessage);
} }
return accessibleErrorMessage; return accessibleErrorMessage;