Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(webkit): make click work with cross-process _blank target (#2083)

Browse source
This commit is contained in:
Yury Semikhatsky 2020-05-02 10:57:33 -07:00 committed by GitHub
parent f2fcb2b017
commit 03ca297890
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/webkit/wkPage.ts
View file

@ -257,8 +257,8 @@ export class WKPage implements PageDelegate {
}); });
assert(targetInfo.type === 'page', 'Only page targets are expected in WebKit, received: ' + targetInfo.type); assert(targetInfo.type === 'page', 'Only page targets are expected in WebKit, received: ' + targetInfo.type);
if (!this._initializedPage) { if (!targetInfo.isProvisional) {
assert(!targetInfo.isProvisional); assert(!this._initializedPage);
let pageOrError: Page | Error; let pageOrError: Page | Error;
try { try {
this._setSession(session); this._setSession(session);

2
test/navigation.spec.js
View file

@ -994,7 +994,7 @@ describe('Click navigation', function() {
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);
await page.click('"Click me"'); await page.click('"Click me"');
}); });
it.fail(WEBKIT)('should work with cross-process _blank target', async({page, server}) => { it('should work with cross-process _blank target', async({page, server}) => {
server.setRoute('/empty.html', (req, res) => { server.setRoute('/empty.html', (req, res) => {
res.end(`<a href="${server.CROSS_PROCESS_PREFIX}/empty.html" target="_blank">Click me</a>`); res.end(`<a href="${server.CROSS_PROCESS_PREFIX}/empty.html" target="_blank">Click me</a>`);
}); });