Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: mark trace-viewer tests as slow, unflake resource order (#11070)

Browse source
This commit is contained in:
Dmitry Gozman 2021-12-22 11:17:43 -08:00 committed by GitHub
parent af153b9826
commit 0514ecc1af
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
tests/trace-viewer/trace-viewer.spec.ts
View file

@ -120,6 +120,7 @@ const test = playwrightTest.extend<{ showTraceViewer: (trace: string) => Promise
}); });
test.skip(({ trace }) => trace === 'on'); test.skip(({ trace }) => trace === 'on');
test.slow();
let traceFile: string; let traceFile: string;
@ -149,9 +150,14 @@ test.beforeAll(async function recordTrace({ browser, browserName, browserType, s
} }
await doClick(); await doClick();
// Make sure resources arrive in a predictable order.
const htmlDone = page.waitForEvent('requestfinished', request => request.url().includes('frame.html'));
const styleDone = page.waitForEvent('requestfinished', request => request.url().includes('style.css')); const styleDone = page.waitForEvent('requestfinished', request => request.url().includes('style.css'));
await page.route(server.PREFIX + '/frames/style.css', async route => {
await htmlDone;
await route.continue();
});
await page.route(server.PREFIX + '/frames/script.js', async route => { await page.route(server.PREFIX + '/frames/script.js', async route => {
// Make sure script arrives after style for predictable results.
await styleDone; await styleDone;
await route.continue(); await route.continue();
}); });
@ -188,11 +194,13 @@ test('should open simple trace viewer', async ({ showTraceViewer }) => {
/page.evaluate/, /page.evaluate/,
/page.click"Click"/, /page.click"Click"/,
/page.waitForEvent/, /page.waitForEvent/,
/page.waitForEvent/,
/page.route/, /page.route/,
/page.waitForNavigation/, /page.waitForNavigation/,
/page.waitForTimeout/, /page.waitForTimeout/,
/page.gotohttp:\/\/localhost:\d+\/frames\/frame.html/, /page.gotohttp:\/\/localhost:\d+\/frames\/frame.html/,
/route.continue/, /route.continue/,
/route.continue/,
/page.setViewportSize/, /page.setViewportSize/,
]); ]);
}); });