Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse source 
Co-authored-by: Simon Knott <info@simonknott.de>
Signed-off-by: Max Schmitt <max@schmitt.mx>
This commit is contained in:
Max Schmitt 2024-08-12 14:59:28 +02:00
parent 3bdf1d458f
commit 05f11f7da3
2 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/playwright-core/src/server/recorder/recorderApp.ts
View file

@ -38,7 +38,7 @@ declare global {
playwrightSetSelector: (selector: string, focus?: boolean) => void; playwrightSetSelector: (selector: string, focus?: boolean) => void;
playwrightUpdateLogs: (callLogs: CallLog[]) => void; playwrightUpdateLogs: (callLogs: CallLog[]) => void;
dispatch(data: EventData): Promise<void>; dispatch(data: EventData): Promise<void>;
saveSettings(): Promise<void>; saveSettings?(): Promise<void>;
} }
} }

9
packages/web/src/uiUtils.ts
View file

@ -167,7 +167,7 @@ export function useSetting<S>(name: string | undefined, defaultValue: S, title?:
declare global { declare global {
interface Window { interface Window {
saveSettings(): Promise<void>; saveSettings?(): Promise<void>;
} }
} }
@ -181,8 +181,7 @@ export class Settings {
setString(name: string, value: string) { setString(name: string, value: string) {
localStorage[name] = value; localStorage[name] = value;
this.onChangeEmitter.dispatchEvent(new Event(name)); this.onChangeEmitter.dispatchEvent(new Event(name));
if (window.saveSettings) window.saveSettings?.();
window.saveSettings();
} }
getObject<T>(name: string, defaultValue: T): T { getObject<T>(name: string, defaultValue: T): T {
@ -198,9 +197,7 @@ export class Settings {
setObject<T>(name: string, value: T) { setObject<T>(name: string, value: T) {
localStorage[name] = JSON.stringify(value); localStorage[name] = JSON.stringify(value);
this.onChangeEmitter.dispatchEvent(new Event(name)); this.onChangeEmitter.dispatchEvent(new Event(name));
window.saveSettings?.();
if (window.saveSettings)
window.saveSettings();
} }
} }