Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: unflake page-drag tests (#17783)

Browse source 
To avoid rounding errors, make coordinates even.
This commit is contained in:
Dmitry Gozman 2022-10-03 12:26:36 -07:00 committed by GitHub
parent 57cde6e671
commit 06e0ea5e24
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 46 additions and 43 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
tests/assets/drag-n-drop.html
View file

@ -1,4 +1,7 @@
<style> <style>
* {
box-sizing: border-box;
}
body, html { body, html {
margin: 0; margin: 0;
padding: 0; padding: 0;

86
tests/page/page-drag.spec.ts
View file

@ -38,22 +38,22 @@ it.describe('Drag and drop', () => {
await page.hover('#target'); await page.hover('#target');
await page.mouse.up(); await page.mouse.up();
expect(await events.jsonValue()).toEqual(browserName === 'firefox' ? [ expect(await events.jsonValue()).toEqual(browserName === 'firefox' ? [
'mousemove at 121;87', 'mousemove at 120;86',
'mousedown at 121;87', 'mousedown at 120;86',
'dragstart at 121;87', 'dragstart at 120;86',
'mousemove at 241;351', 'mousemove at 240;350',
'dragenter at 0;0', 'dragenter at 0;0',
'dragover at 0;0', 'dragover at 0;0',
'drop at 0;0', 'drop at 0;0',
'dragend', 'dragend',
] : [ ] : [
'mousemove at 121;87', 'mousemove at 120;86',
'mousedown at 121;87', 'mousedown at 120;86',
'mousemove at 241;351', 'mousemove at 240;350',
'dragstart at 121;87', 'dragstart at 120;86',
'dragenter at 241;351', 'dragenter at 240;350',
'dragover at 241;351', 'dragover at 240;350',
'drop at 241;351', 'drop at 240;350',
'dragend', 'dragend',
]); ]);
}); });
@ -67,17 +67,17 @@ it.describe('Drag and drop', () => {
await page.mouse.down(); await page.mouse.down();
await page.hover('#target'); await page.hover('#target');
expect(await events.jsonValue()).toEqual(browserName === 'firefox' ? [ expect(await events.jsonValue()).toEqual(browserName === 'firefox' ? [
'mousemove at 121;87', 'mousemove at 120;86',
'mousedown at 121;87', 'mousedown at 120;86',
'dragstart at 121;87', 'dragstart at 120;86',
'mousemove at 241;351', 'mousemove at 240;350',
'dragenter at 0;0', 'dragenter at 0;0',
] : [ ] : [
'mousemove at 121;87', 'mousemove at 120;86',
'mousedown at 121;87', 'mousedown at 120;86',
'mousemove at 241;351', 'mousemove at 240;350',
'dragstart at 121;87', 'dragstart at 120;86',
'dragenter at 241;351', 'dragenter at 240;350',
]); ]);
}); });
@ -98,22 +98,22 @@ it.describe('Drag and drop', () => {
await page.mouse.up(); await page.mouse.up();
expect(await frame.$eval('#target', target => target.contains(document.querySelector('#source')))).toBe(true); // could not find source in target expect(await frame.$eval('#target', target => target.contains(document.querySelector('#source')))).toBe(true); // could not find source in target
expect(await frameEvents.jsonValue()).toEqual(browserName === 'firefox' ? [ expect(await frameEvents.jsonValue()).toEqual(browserName === 'firefox' ? [
'mousemove at 121;87', 'mousemove at 120;86',
'mousedown at 121;87', 'mousedown at 120;86',
'dragstart at 121;87', 'dragstart at 120;86',
'mousemove at 241;351', 'mousemove at 240;350',
'dragenter at 0;0', 'dragenter at 0;0',
'dragover at 0;0', 'dragover at 0;0',
'drop at 0;0', 'drop at 0;0',
'dragend', 'dragend',
] : [ ] : [
'mousemove at 121;87', 'mousemove at 120;86',
'mousedown at 121;87', 'mousedown at 120;86',
'mousemove at 241;351', 'mousemove at 240;350',
'dragstart at 121;87', 'dragstart at 120;86',
'dragenter at 241;351', 'dragenter at 240;350',
'dragover at 241;351', 'dragover at 240;350',
'drop at 241;351', 'drop at 240;350',
'dragend', 'dragend',
]); ]);
expect(await pageEvents.jsonValue()).toEqual([]); expect(await pageEvents.jsonValue()).toEqual([]);
@ -129,23 +129,23 @@ it.describe('Drag and drop', () => {
await page.mouse.up(); await page.mouse.up();
expect(await page.$eval('#target', target => target.contains(document.querySelector('#source')))).toBe(false); // found source in target expect(await page.$eval('#target', target => target.contains(document.querySelector('#source')))).toBe(false); // found source in target
expect(await events.jsonValue()).toEqual(browserName === 'firefox' ? [ expect(await events.jsonValue()).toEqual(browserName === 'firefox' ? [
'mousemove at 121;87', 'mousemove at 120;86',
'mousedown at 121;87', 'mousedown at 120;86',
'dragstart at 121;87', 'dragstart at 120;86',
'mousemove at 241;351', 'mousemove at 240;350',
'dragenter at 0;0', 'dragenter at 0;0',
'dragover at 0;0', 'dragover at 0;0',
'dragend', 'dragend',
'mouseup at 241;351', 'mouseup at 240;350',
] : [ ] : [
'mousemove at 121;87', 'mousemove at 120;86',
'mousedown at 121;87', 'mousedown at 120;86',
'mousemove at 241;351', 'mousemove at 240;350',
'dragstart at 121;87', 'dragstart at 120;86',
'dragenter at 241;351', 'dragenter at 240;350',
browserName === 'chromium' ? null : 'dragover at 241;351', browserName === 'chromium' ? null : 'dragover at 240;350',
'dragend', 'dragend',
'mouseup at 241;351', 'mouseup at 240;350',
].filter(Boolean)); ].filter(Boolean));
}); });