Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore(bidi): Stop dividing BiDi network event timings by 1000 (#34324)

Browse source
This commit is contained in:
Julian Descottes 2025-01-15 00:27:49 +01:00 committed by GitHub
parent 8699d3b9c5
commit 0869195ba4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/playwright-core/src/server/bidi/bidiNetworkManager.ts
View file

@ -96,10 +96,10 @@ export class BidiNetworkManager {
function relativeToStart(time: number): number { function relativeToStart(time: number): number {
if (!time) if (!time)
return -1; return -1;
return (time - startTime) / 1000; return (time - startTime);
} }
const timing: network.ResourceTiming = { const timing: network.ResourceTiming = {
startTime: startTime / 1000, startTime: startTime,
requestStart: relativeToStart(timings.requestStart), requestStart: relativeToStart(timings.requestStart),
responseStart: relativeToStart(timings.responseStart), responseStart: relativeToStart(timings.responseStart),
domainLookupStart: relativeToStart(timings.dnsStart), domainLookupStart: relativeToStart(timings.dnsStart),
@ -130,7 +130,7 @@ export class BidiNetworkManager {
// Keep redirected requests in the map for future reference as redirectedFrom. // Keep redirected requests in the map for future reference as redirectedFrom.
const isRedirected = response.status() >= 300 && response.status() <= 399; const isRedirected = response.status() >= 300 && response.status() <= 399;
const responseEndTime = params.request.timings.responseEnd / 1000 - response.timing().startTime; const responseEndTime = params.request.timings.responseEnd - response.timing().startTime;
if (isRedirected) { if (isRedirected) {
response._requestFinished(responseEndTime); response._requestFinished(responseEndTime);
} else { } else {