Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

make contextId optional in trace file

Browse source
This commit is contained in:
Yury Semikhatsky 2025-02-06 11:38:58 -08:00
parent 06e564b3f6
commit 19664d172f
3 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
packages/playwright/src/worker/testTracing.ts
View file

@ -58,7 +58,6 @@ export class TestTracing {
wallTime: Date.now(), wallTime: Date.now(),
monotonicTime: monotonicTime(), monotonicTime: monotonicTime(),
sdkLanguage: 'javascript', sdkLanguage: 'javascript',
contextId: '',
}; };
this._appendTraceEvent(this._contextCreatedEvent); this._appendTraceEvent(this._contextCreatedEvent);
} }

2
packages/trace-viewer/src/sw/traceModernizer.ts
View file

@ -92,7 +92,7 @@ export class TraceModernizer {
contextEntry.sdkLanguage = event.sdkLanguage; contextEntry.sdkLanguage = event.sdkLanguage;
contextEntry.options = event.options; contextEntry.options = event.options;
contextEntry.testIdAttributeName = event.testIdAttributeName; contextEntry.testIdAttributeName = event.testIdAttributeName;
contextEntry.contextId = event.contextId; contextEntry.contextId = event.contextId ?? '';
break; break;
} }
case 'screencast-frame': { case 'screencast-frame': {

2
packages/trace/src/trace.ts
View file

@ -44,7 +44,7 @@ export type ContextCreatedTraceEvent = {
options: BrowserContextEventOptions, options: BrowserContextEventOptions,
sdkLanguage?: Language, sdkLanguage?: Language,
testIdAttributeName?: string, testIdAttributeName?: string,
contextId: string, contextId?: string,
}; };
export type ScreencastFrameTraceEvent = { export type ScreencastFrameTraceEvent = {