Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: unflake page-click.spec.ts test (#11050)

Browse source
This commit is contained in:
Andrey Lushnikov 2021-12-21 17:31:13 -08:00 committed by GitHub
parent 9294947862
commit 1ee2d01f1c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
tests/page/page-click.spec.ts
View file

@ -834,11 +834,14 @@ it('should not hang when frame is detached', async ({ page, server, mode }) => {
button.style.marginLeft = '200px'; button.style.marginLeft = '200px';
}); });
let detachPromise; let resolveDetachPromise;
const detachPromise = new Promise(resolve => resolveDetachPromise = resolve);
const __testHookBeforeStable = () => { const __testHookBeforeStable = () => {
// Detach the frame after "waiting for stable" has started. // Detach the frame after "waiting for stable" has started.
setTimeout(() => {
detachPromise = detachFrame(page, 'frame1'); setTimeout(async () => {
await detachFrame(page, 'frame1');
resolveDetachPromise();
}, 1000); }, 1000);
}; };
const promise = frame.click('button', { __testHookBeforeStable } as any).catch(e => e); const promise = frame.click('button', { __testHookBeforeStable } as any).catch(e => e);