Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: skip and unflake tests (#23399)

Browse source 
- `should respect tracesDir and name` does not work with service mode;
- `isVisible during navigation should not throw` had a short timeout.
This commit is contained in:
Dmitry Gozman 2023-05-31 10:52:29 -07:00 committed by GitHub
parent 4eeb4655e9
commit 2505d48b32
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tests/library/tracing.spec.ts
View file

@ -182,7 +182,9 @@ test('should collect two traces', async ({ context, page, server }, testInfo) =>
} }
}); });
test('should respect tracesDir and name', async ({ browserType, server }, testInfo) => { test('should respect tracesDir and name', async ({ browserType, server, mode }, testInfo) => {
test.skip(mode === 'service', 'Service ignores tracesDir');
const tracesDir = testInfo.outputPath('traces'); const tracesDir = testInfo.outputPath('traces');
const browser = await browserType.launch({ tracesDir }); const browser = await browserType.launch({ tracesDir });
const context = await browser.newContext(); const context = await browser.newContext();

4
tests/page/locator-is-visible.spec.ts
View file

@ -88,15 +88,13 @@ it('isVisible inside a role=button', async ({ page }) => {
it('isVisible during navigation should not throw', async ({ page, server }) => { it('isVisible during navigation should not throw', async ({ page, server }) => {
for (let i = 0; i < 20; i++) { for (let i = 0; i < 20; i++) {
// Make sure previous navigation finishes, to avoid page.setContent throwing.
await page.waitForTimeout(100);
await page.setContent(` await page.setContent(`
<script> <script>
setTimeout(() => { setTimeout(() => {
window.location.href = ${JSON.stringify(server.EMPTY_PAGE)}; window.location.href = ${JSON.stringify(server.EMPTY_PAGE)};
}, Math.random(50)); }, Math.random(50));
</script> </script>
`); `).catch(() => {}); // Avoid page.setContent throwing becuase of scheduled navigation.
expect(await page.locator('div').isVisible()).toBe(false); expect(await page.locator('div').isVisible()).toBe(false);
} }
}); });