Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

devops: remove explicit npm@8 installation (#23096)

Browse source 
Node 16+ comes with npm 8+ by default.
This commit is contained in:
Yury Semikhatsky 2023-05-17 14:32:38 -07:00 committed by GitHub
parent 0318b85216
commit 27403dcbb4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 41 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
.github/workflows/tests_primary.yml vendored
View file

@ -33,11 +33,8 @@ jobs:
matrix: matrix:
browser: [chromium, firefox, webkit] browser: [chromium, firefox, webkit]
os: [ubuntu-22.04] os: [ubuntu-22.04]
node-version: [14] node-version: [16]
include: include:
- os: ubuntu-22.04
node-version: 16
browser: chromium
- os: ubuntu-22.04 - os: ubuntu-22.04
node-version: 18 node-version: 18
browser: chromium browser: chromium
@ -47,7 +44,6 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: ${{ matrix.node-version }} node-version: ${{ matrix.node-version }}
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
DEBUG: pw:install DEBUG: pw:install
@ -108,7 +104,6 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: 16 node-version: 16
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
DEBUG: pw:install DEBUG: pw:install
@ -148,7 +143,6 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: ${{matrix.node-version}} node-version: ${{matrix.node-version}}
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
DEBUG: pw:install DEBUG: pw:install
@ -204,7 +198,6 @@ jobs:
with: with:
# Component tests require Node.js 16+ (they require ESM via TS) # Component tests require Node.js 16+ (they require ESM via TS)
node-version: 16 node-version: 16
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
DEBUG: pw:install DEBUG: pw:install
@ -215,7 +208,7 @@ jobs:
if: always() if: always()
test-package-installations: test-package-installations:
name: "Installation Test ${{ matrix.os }} (${{ matrix.node_version }})" name: "Installation Test ${{ matrix.os }}"
runs-on: ${{ matrix.os }} runs-on: ${{ matrix.os }}
strategy: strategy:
fail-fast: false fail-fast: false
@ -224,15 +217,12 @@ jobs:
- ubuntu-latest - ubuntu-latest
- macos-latest - macos-latest
- windows-latest - windows-latest
node_version:
- "^14.1.0" # pre 14.1, zip extraction was broken (https://github.com/microsoft/playwright/issues/1988)
timeout-minutes: 30 timeout-minutes: 30
steps: steps:
- uses: actions/checkout@v3 - uses: actions/checkout@v3
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: ${{ matrix.node_version }} node-version: 16
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
DEBUG: pw:install DEBUG: pw:install

28
.github/workflows/tests_secondary.yml vendored
View file

@ -34,7 +34,6 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: 16 node-version: 16
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
DEBUG: pw:install DEBUG: pw:install
@ -65,7 +64,6 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: 16 node-version: 16
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
DEBUG: pw:install DEBUG: pw:install
@ -94,7 +92,6 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: 16 node-version: 16
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
DEBUG: pw:install DEBUG: pw:install
@ -129,7 +126,6 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: ${{ matrix.node_version }} node-version: ${{ matrix.node_version }}
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
DEBUG: pw:install DEBUG: pw:install
@ -156,7 +152,6 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: 16 node-version: 16
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
DEBUG: pw:install DEBUG: pw:install
@ -188,7 +183,6 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: 16 node-version: 16
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
DEBUG: pw:install DEBUG: pw:install
@ -224,7 +218,6 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: 16 node-version: 16
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
DEBUG: pw:install DEBUG: pw:install
@ -247,7 +240,6 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: 16 node-version: 16
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
@ -273,7 +265,6 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: 16 node-version: 16
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
@ -300,7 +291,6 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: 16 node-version: 16
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
@ -330,7 +320,6 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: 16 node-version: 16
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
@ -365,7 +354,6 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: 16 node-version: 16
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
@ -396,7 +384,6 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: 16 node-version: 16
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
@ -422,7 +409,6 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: 16 node-version: 16
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
@ -449,7 +435,6 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: 16 node-version: 16
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
@ -475,7 +460,6 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: 16 node-version: 16
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
@ -502,7 +486,6 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: 16 node-version: 16
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
@ -529,7 +512,6 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: 16 node-version: 16
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
@ -555,7 +537,6 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: 16 node-version: 16
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
@ -581,7 +562,6 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: 16 node-version: 16
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
@ -608,7 +588,6 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: 16 node-version: 16
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
@ -634,7 +613,6 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: 16 node-version: 16
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
@ -660,7 +638,6 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: 16 node-version: 16
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
@ -687,7 +664,6 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: 16 node-version: 16
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
@ -713,7 +689,6 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: 16 node-version: 16
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
@ -739,7 +714,6 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: 16 node-version: 16
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
@ -766,7 +740,6 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: 16 node-version: 16
- run: npm i -g npm@8
- run: npm ci - run: npm ci
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
@ -792,7 +765,6 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: 16 node-version: 16
- run: npm i -g npm@8
- run: npm ci - run: npm ci
- run: npm run build - run: npm run build
- run: npx playwright install-deps - run: npx playwright install-deps