Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore: fix racy emptyOutDir in trace-viewer build (#20090)

Browse source
This commit is contained in:
Dmitry Gozman 2023-01-13 06:42:56 -08:00 committed by GitHub
parent e065d608b6
commit 3a1eb2abda
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/trace-viewer/vite.config.ts
View file

@ -35,7 +35,8 @@ export default defineConfig({
}, },
build: { build: {
outDir: path.resolve(__dirname, '../playwright-core/lib/webpack/traceViewer'), outDir: path.resolve(__dirname, '../playwright-core/lib/webpack/traceViewer'),
emptyOutDir: true, // Output dir is shared with vite.sw.config.ts, clearing it here is racy.
emptyOutDir: false,
rollupOptions: { rollupOptions: {
output: { output: {
entryFileNames: () => '[name].[hash].js', entryFileNames: () => '[name].[hash].js',

2
packages/trace-viewer/vite.sw.config.ts
View file

@ -35,6 +35,8 @@ export default defineConfig({
}, },
build: { build: {
outDir: path.resolve(__dirname, '../playwright-core/lib/webpack/traceViewer'), outDir: path.resolve(__dirname, '../playwright-core/lib/webpack/traceViewer'),
// Output dir is shared with vite.config.ts, clearing it here is racy.
emptyOutDir: false,
rollupOptions: { rollupOptions: {
input: { input: {
sw: path.resolve(__dirname, 'src/sw.ts'), sw: path.resolve(__dirname, 'src/sw.ts'),