Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

feat(socket): destroy contexts upon disconnect (#1119)

Browse source
This commit is contained in:
Pavel Feldman 2020-02-26 11:01:01 -08:00 committed by GitHub
parent 72fa945689
commit 3afaeef557
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/chromium/crBrowser.ts
View file

@ -68,7 +68,7 @@ export class CRBrowser extends platform.EventEmitter implements Browser {
async newContext(options: BrowserContextOptions = {}): Promise<BrowserContext> { async newContext(options: BrowserContextOptions = {}): Promise<BrowserContext> {
options = validateBrowserContextOptions(options); options = validateBrowserContextOptions(options);
const { browserContextId } = await this._client.send('Target.createBrowserContext'); const { browserContextId } = await this._client.send('Target.createBrowserContext', { disposeOnDetach: true });
const context = new CRBrowserContext(this, browserContextId, options); const context = new CRBrowserContext(this, browserContextId, options);
await context._initialize(); await context._initialize();
this._contexts.set(browserContextId, context); this._contexts.set(browserContextId, context);

1
src/firefox/ffBrowser.ts
View file

@ -90,6 +90,7 @@ export class FFBrowser extends platform.EventEmitter implements Browser {
bypassCSP: options.bypassCSP, bypassCSP: options.bypassCSP,
javaScriptDisabled: options.javaScriptEnabled === false ? true : undefined, javaScriptDisabled: options.javaScriptEnabled === false ? true : undefined,
viewport, viewport,
removeOnDetach: true
}); });
// TODO: move ignoreHTTPSErrors to browser context level. // TODO: move ignoreHTTPSErrors to browser context level.
if (options.ignoreHTTPSErrors) if (options.ignoreHTTPSErrors)