Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: fix socks proxy test for wk mac (#20227)

Browse source 
Drive-by: unskip firefox test.
This commit is contained in:
Dmitry Gozman 2023-01-19 09:10:42 -08:00 committed by GitHub
parent 1b8b20dc25
commit 3f79786cf8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
tests/library/browsertype-connect.spec.ts
View file

@ -825,16 +825,16 @@ for (const kind of ['launchServer', 'run-server'] as const) {
}); });
const remoteServer = await startRemoteServer(kind); const remoteServer = await startRemoteServer(kind);
const browser = await connect(remoteServer.wsEndpoint(), { const browser = await connect(remoteServer.wsEndpoint(), {
_exposeNetwork: 'localhost', _exposeNetwork: '127.0.0.1',
headers: { headers: {
'x-playwright-proxy': '*', 'x-playwright-proxy': '*',
}, },
} as any, dummyServerPort); } as any, dummyServerPort);
const page = await browser.newPage(); const page = await browser.newPage();
// 127.0.0.1 should fail on the client side. // local.playwright should fail on the client side.
let failed = false; let failed = false;
await page.goto(`http://127.0.0.1:${server.PORT}/foo.html`).catch(e => { await page.goto(`http://local.playwright:${server.PORT}/foo.html`).catch(e => {
failed = true; failed = true;
}); });
expect(failed).toBe(true); expect(failed).toBe(true);

1
tests/library/defaultbrowsercontext-2.spec.ts
View file

@ -96,7 +96,6 @@ it('should accept userDataDir', async ({ createUserDataDir, browserType }) => {
}); });
it('should restore state from userDataDir', async ({ browserType, server, createUserDataDir, isMac, browserName }) => { it('should restore state from userDataDir', async ({ browserType, server, createUserDataDir, isMac, browserName }) => {
it.fixme(browserName === 'firefox', 'https://github.com/microsoft/playwright/issues/12632');
it.slow(); it.slow();
const userDataDir = await createUserDataDir(); const userDataDir = await createUserDataDir();