Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(pipe): sort out pipes on platforms (#895)

Browse source
This commit is contained in:
Pavel Feldman 2020-02-07 11:48:55 -08:00 committed by GitHub
parent 0ed43e8781
commit 42c2cfc7cc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/server/processLauncher.ts
View file

@ -49,13 +49,7 @@ let lastLaunchedId = 0;
export async function launchProcess(options: LaunchProcessOptions): Promise<LaunchResult> { export async function launchProcess(options: LaunchProcessOptions): Promise<LaunchResult> {
const id = ++lastLaunchedId; const id = ++lastLaunchedId;
let stdio: ('ignore' | 'pipe')[] = ['pipe', 'pipe', 'pipe']; const stdio: ('ignore' | 'pipe')[] = options.pipe ? ['ignore', 'pipe', 'pipe', 'pipe', 'pipe'] : ['ignore', 'pipe', 'pipe'];
if (options.pipe) {
if (options.dumpio)
stdio = ['ignore', 'pipe', 'pipe', 'pipe', 'pipe'];
else
stdio = ['ignore', 'ignore', 'ignore', 'pipe', 'pipe'];
}
const spawnedProcess = childProcess.spawn( const spawnedProcess = childProcess.spawn(
options.executablePath, options.executablePath,
options.args, options.args,
@ -80,8 +74,11 @@ export async function launchProcess(options: LaunchProcessOptions): Promise<Laun
} }
if (options.dumpio) { if (options.dumpio) {
spawnedProcess.stderr.pipe(process.stderr);
spawnedProcess.stdout.pipe(process.stdout); spawnedProcess.stdout.pipe(process.stdout);
spawnedProcess.stderr.pipe(process.stderr);
} else {
spawnedProcess.stderr.on('data', () => {});
spawnedProcess.stdout.on('data', () => {});
} }
let processClosed = false; let processClosed = false;