Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore: do not generate role= selector, use internal (#18519)

Browse source
This commit is contained in:
Pavel Feldman 2022-11-02 14:57:19 -07:00 committed by GitHub
parent b2e4f5652e
commit 4d34a1a371
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/playwright-core/src/server/injected/selectorGenerator.ts
View file

@ -215,9 +215,9 @@ function buildTextCandidates(injectedScript: InjectedScript, element: Element, i
if (ariaRole) { if (ariaRole) {
const ariaName = getElementAccessibleName(element, false, accessibleNameCache); const ariaName = getElementAccessibleName(element, false, accessibleNameCache);
if (ariaName) if (ariaName)
candidate.push({ engine: 'role', selector: `${ariaRole}[name=${escapeForAttributeSelector(ariaName, true)}]`, score: 10 }); candidate.push({ engine: 'internal:role', selector: `${ariaRole}[name=${escapeForAttributeSelector(ariaName, true)}]`, score: 10 });
else else
candidate.push({ engine: 'role', selector: ariaRole, score: 10 }); candidate.push({ engine: 'internal:role', selector: ariaRole, score: 10 });
} else { } else {
candidate.push({ engine: 'css', selector: element.nodeName.toLowerCase(), score: 10 }); candidate.push({ engine: 'css', selector: element.nodeName.toLowerCase(), score: 10 });
} }