Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: enable "should record open in a new tab with url" on webkit (#11917)

Browse source
This commit is contained in:
Dmitry Gozman 2022-02-07 16:09:11 -08:00 committed by GitHub
parent 9116adc684
commit 4ef22d3387
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
tests/inspector/cli-codegen-2.spec.ts
View file

@ -364,8 +364,6 @@ test.describe('cli codegen', () => {
}); });
test('should record open in a new tab with url', async ({ page, openRecorder, browserName, platform }) => { test('should record open in a new tab with url', async ({ page, openRecorder, browserName, platform }) => {
test.fixme(browserName === 'webkit', 'Ctrl+click does not open in new tab on WebKit');
const recorder = await openRecorder(); const recorder = await openRecorder();
await recorder.setContentAndWait(`<a href="about:blank?foo">link</a>`); await recorder.setContentAndWait(`<a href="about:blank?foo">link</a>`);
@ -375,7 +373,7 @@ test.describe('cli codegen', () => {
await page.click('a', { modifiers: [ platform === 'darwin' ? 'Meta' : 'Control'] }); await page.click('a', { modifiers: [ platform === 'darwin' ? 'Meta' : 'Control'] });
const sources = await recorder.waitForOutput('JavaScript', 'page1'); const sources = await recorder.waitForOutput('JavaScript', 'page1');
if (browserName === 'chromium') { if (browserName !== 'firefox') {
expect(sources.get('JavaScript').text).toContain(` expect(sources.get('JavaScript').text).toContain(`
// Open new page // Open new page
const page1 = await context.newPage(); const page1 = await context.newPage();
@ -388,7 +386,7 @@ test.describe('cli codegen', () => {
// Open new page // Open new page
var page1 = await context.NewPageAsync(); var page1 = await context.NewPageAsync();
await page1.GotoAsync("about:blank?foo");`); await page1.GotoAsync("about:blank?foo");`);
} else if (browserName === 'firefox') { } else {
expect(sources.get('JavaScript').text).toContain(` expect(sources.get('JavaScript').text).toContain(`
// Click text=link // Click text=link
const [page1] = await Promise.all([ const [page1] = await Promise.all([