Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: unskip WK tests (#21033)

Browse source 
Fixes https://github.com/microsoft/playwright/issues/20370
Fixes https://github.com/microsoft/playwright/issues/12353
This commit is contained in:
Max Schmitt 2023-02-21 23:49:14 +01:00 committed by GitHub
parent 06fc72b6ed
commit 4efa9e5ea0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
tests/library/browsercontext-add-cookies.spec.ts
View file

@ -454,8 +454,7 @@ it('should allow unnamed cookies', async ({ page, context, server, browserName,
expect.soft(await page.evaluate('document.cookie')).toBe('unnamed-via-js'); expect.soft(await page.evaluate('document.cookie')).toBe('unnamed-via-js');
}); });
it('should set cookies on WebSocket', async ({ contextFactory, httpsServer, browserName, platform }) => { it('should set secure cookies on secure WebSocket', async ({ contextFactory, httpsServer }) => {
it.fixme(browserName === 'webkit' && platform === 'win32', 'WebKit on win32 does not send any cookies over the WebSocket connection');
let resolveResceivedWebSocketHeaders = (headers: IncomingHttpHeaders) => { }; let resolveResceivedWebSocketHeaders = (headers: IncomingHttpHeaders) => { };
const receivedWebSocketHeaders = new Promise<IncomingHttpHeaders>(resolve => resolveResceivedWebSocketHeaders = resolve); const receivedWebSocketHeaders = new Promise<IncomingHttpHeaders>(resolve => resolveResceivedWebSocketHeaders = resolve);
httpsServer.onceWebSocketConnection((ws, req) => resolveResceivedWebSocketHeaders(req.headers)); httpsServer.onceWebSocketConnection((ws, req) => resolveResceivedWebSocketHeaders(req.headers));

5
tests/library/capabilities.spec.ts
View file

@ -168,15 +168,14 @@ it('should not crash on storage.getDirectory()', async ({ page, server, browserN
} }
}); });
it('navigator.clipboard should be present', async ({ page, server, browserName, browserMajorVersion }) => { it('navigator.clipboard should be present', async ({ page, server }) => {
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/18901' }); it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/18901' });
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);
expect(await page.evaluate(() => navigator.clipboard)).toBeTruthy(); expect(await page.evaluate(() => navigator.clipboard)).toBeTruthy();
}); });
it('should set CloseEvent.wasClean to false when the server terminates a WebSocket connection', async ({ page, server, browserName, platform }) => { it('should set CloseEvent.wasClean to false when the server terminates a WebSocket connection', async ({ page, server }) => {
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/12353' }); it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/12353' });
it.fixme(browserName === 'webkit' && platform === 'win32');
server.onceWebSocketConnection(socket => { server.onceWebSocketConnection(socket => {
socket.terminate(); socket.terminate();
}); });