Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

devops: fix --full command in FF which installs deps (#8878)

Browse source 
Broken since https://github.com/microsoft/playwright/pull/8049

Previously when doing `build.sh --full` it was installing deps + building. Currently when passing `--full` it does not install the deps before, since it tries to compile before.
This commit is contained in:
Max Schmitt 2021-09-13 17:01:35 +02:00 committed by GitHub
parent ec2cbad76f
commit 5953472899
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
browser_patches/firefox-beta/build.sh
View file

@ -102,7 +102,6 @@ if [[ $1 != "--juggler" ]]; then
echo "-- Using cbindgen v${CBINDGEN_VERSION}" echo "-- Using cbindgen v${CBINDGEN_VERSION}"
cargo install cbindgen --version "${CBINDGEN_VERSION}" cargo install cbindgen --version "${CBINDGEN_VERSION}"
fi fi
./mach build
fi fi
if [[ $1 == "--full" || $2 == "--full" ]]; then if [[ $1 == "--full" || $2 == "--full" ]]; then
@ -121,6 +120,8 @@ fi
if [[ $1 == "--juggler" ]]; then if [[ $1 == "--juggler" ]]; then
./mach build faster ./mach build faster
else
./mach build
fi fi
if [[ "$(uname)" == "Darwin" ]]; then if [[ "$(uname)" == "Darwin" ]]; then

3
browser_patches/firefox/build.sh
View file

@ -102,7 +102,6 @@ if [[ $1 != "--juggler" ]]; then
echo "-- Using cbindgen v${CBINDGEN_VERSION}" echo "-- Using cbindgen v${CBINDGEN_VERSION}"
cargo install cbindgen --version "${CBINDGEN_VERSION}" cargo install cbindgen --version "${CBINDGEN_VERSION}"
fi fi
./mach build
fi fi
if [[ $1 == "--full" || $2 == "--full" ]]; then if [[ $1 == "--full" || $2 == "--full" ]]; then
@ -121,6 +120,8 @@ fi
if [[ $1 == "--juggler" ]]; then if [[ $1 == "--juggler" ]]; then
./mach build faster ./mach build faster
else
./mach build
fi fi
if [[ "$(uname)" == "Darwin" ]]; then if [[ "$(uname)" == "Darwin" ]]; then