Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(headers): fix webkit win headers tests (#8675)

Browse source
This commit is contained in:
Pavel Feldman 2021-09-02 22:05:22 -07:00 committed by GitHub
parent c6cfa6f69d
commit 5ac11a7760
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/server/webkit/wkInterceptableRequest.ts
View file

@ -89,7 +89,7 @@ export class WKInterceptableRequest {
requestStart: timingPayload ? wkMillisToRoundishMillis(timingPayload.requestStart) : -1,
responseStart: timingPayload ? wkMillisToRoundishMillis(timingPayload.responseStart) : -1,
};
const setCookieSeparator = process.platform === 'linux' ? '\n' : ',';
const setCookieSeparator = process.platform === 'darwin' ? ',' : '\n';
return new network.Response(this.request, responsePayload.status, responsePayload.statusText, headersObjectToArray(responsePayload.headers, ',', setCookieSeparator), timing, getResponseBody);
}
}

5
tests/page/page-network-request.spec.ts
View file

@ -271,9 +271,12 @@ it('should report all headers', async ({ page, server, browserName, platform })
server.setRoute('/headers', (req, res) => {
for (let i = 0; i < req.rawHeaders.length; i += 2)
expectedHeaders[req.rawHeaders[i].toLowerCase()] = req.rawHeaders[i + 1];
if (browserName === 'webkit' && platform === 'win32') {
delete expectedHeaders['accept-encoding'];
delete expectedHeaders['accept-language'];
}
res.end();
});
await page.goto(server.EMPTY_PAGE);
const [request] = await Promise.all([
page.waitForRequest('**/*'),

3
tests/page/page-network-response.spec.ts
View file

@ -118,7 +118,8 @@ it('should return status text', async ({page, server}) => {
expect(response.statusText()).toBe('cool!');
});
it('should report all headers', async ({ page, server }) => {
it('should report all headers', async ({ page, server, browserName, platform }) => {
it.fixme(browserName === 'webkit' && platform === 'win32', 'libcurl does not support non-set-cookie multivalue headers');
const expectedHeaders = {
'header-a': ['value-a', 'value-a-1', 'value-a-2'],
'header-b': ['value-b'],