Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore: render readable title separator in errors (#19754)

Browse source
This commit is contained in:
Pavel Feldman 2023-01-09 09:33:09 -08:00 committed by GitHub
parent bb275cccb6
commit 6083926111
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/playwright-test/src/reporters/base.ts
View file

@ -99,8 +99,7 @@ export class BaseReporter implements ReporterInternal {
} }
onError(error: TestError) { onError(error: TestError) {
if (!(error as any).__isNotAFatalError) this._fatalErrors.push(error);
this._fatalErrors.push(error);
} }
async onEnd(result: FullResult) { async onEnd(result: FullResult) {

2
packages/playwright-test/src/runner.ts
View file

@ -945,7 +945,7 @@ function createDuplicateTitlesErrors(config: FullConfigInternal, rootSuite: Suit
for (const fileSuite of rootSuite.suites) { for (const fileSuite of rootSuite.suites) {
const testsByFullTitle = new Map<string, TestCase>(); const testsByFullTitle = new Map<string, TestCase>();
for (const test of fileSuite.allTests()) { for (const test of fileSuite.allTests()) {
const fullTitle = test.titlePath().slice(2).join('\x1e'); const fullTitle = test.titlePath().slice(2).join(' › ');
const existingTest = testsByFullTitle.get(fullTitle); const existingTest = testsByFullTitle.get(fullTitle);
if (existingTest) { if (existingTest) {
const error: TestError = { const error: TestError = {