Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(tests): fix test that was leaking a context (#933)

Browse source
This commit is contained in:
Joel Einbinder 2020-02-11 14:15:30 -08:00 committed by GitHub
parent aae5fca237
commit 6105d8a26a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
test/browser.spec.js
View file

@ -42,6 +42,7 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, WE
const page = await browser.newPage(); const page = await browser.newPage();
let error; let error;
await page.context().newPage().catch(e => error = e); await page.context().newPage().catch(e => error = e);
await page.close();
expect(error.message).toContain('Please use browser.newContext()'); expect(error.message).toContain('Please use browser.newContext()');
}); });
}); });

1
test/playwright.spec.js
View file

@ -118,6 +118,7 @@ module.exports.describe = ({testRunner, product, playwrightPath}) => {
state.tearDown = async () => { state.tearDown = async () => {
await Promise.all(contexts.map(c => c.close())); await Promise.all(contexts.map(c => c.close()));
expect((await state.browser.contexts()).length).toBe(0, `"${test.fullName}" leaked a context`);
if (rl) { if (rl) {
rl.removeListener('line', onLine); rl.removeListener('line', onLine);
rl.close(); rl.close();