Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

walk back on bash claim

Browse source
This commit is contained in:
Simon Knott 2024-12-22 12:36:21 +01:00
parent 71bce85f1f
commit 6c85be4a2f
No known key found for this signature in database
GPG key ID: 8CEDC00028084AEC
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/playwright/src/plugins/webServerPlugin.ts
View file

@ -125,7 +125,7 @@ export class WebServerPlugin implements TestRunnerPlugin {
throw new Error('skip graceful shutdown'); throw new Error('skip graceful shutdown');
// proper usage of SIGINT is to send it to the entire process group, see https://www.cons.org/cracauer/sigint.html // proper usage of SIGINT is to send it to the entire process group, see https://www.cons.org/cracauer/sigint.html
// there's no such convention for SIGTERM, but we follow GNU bash behaviour, which is also sending to the entire process group // there's no such convention for SIGTERM, so we decide what we want. signaling the process group for consistency.
process.kill(-launchedProcess.pid!, signal); process.kill(-launchedProcess.pid!, signal);
return new Promise<void>((resolve, reject) => { return new Promise<void>((resolve, reject) => {