Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

review feedback

Browse source
This commit is contained in:
Max Schmitt 2024-11-04 11:45:04 +01:00
parent 6df2ec0168
commit 762dc780cc
6 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/playwright-core/src/server/bidi/bidiChromium.ts
View file

@ -112,7 +112,7 @@ export class BidiChromium extends BrowserType {
if (options.devtools) if (options.devtools)
chromeArguments.push('--auto-open-devtools-for-tabs'); chromeArguments.push('--auto-open-devtools-for-tabs');
if (options.headless) { if (options.headless) {
chromeArguments.push('--headless=new'); chromeArguments.push('--headless');
chromeArguments.push( chromeArguments.push(
'--hide-scrollbars', '--hide-scrollbars',

2
packages/playwright-core/src/server/chromium/chromium.ts
View file

@ -309,7 +309,7 @@ export class Chromium extends BrowserType {
if (options.devtools) if (options.devtools)
chromeArguments.push('--auto-open-devtools-for-tabs'); chromeArguments.push('--auto-open-devtools-for-tabs');
if (options.headless) { if (options.headless) {
chromeArguments.push('--headless=new'); chromeArguments.push('--headless');
chromeArguments.push( chromeArguments.push(
'--hide-scrollbars', '--hide-scrollbars',

2
tests/library/download.spec.ts
View file

@ -637,7 +637,7 @@ it('should be able to download a inline PDF file via response interception', asy
}); });
it('should be able to download a inline PDF file via navigation', async ({ browser, server, asset, browserName, channel }) => { it('should be able to download a inline PDF file via navigation', async ({ browser, server, asset, browserName, channel }) => {
it.skip(browserName === 'chromium' && channel !== 'chromium-headless-shell'); it.skip(browserName === 'chromium' && channel !== 'chromium-headless-shell', 'We expect PDF Viewer to open up in Chromium');
const page = await browser.newPage(); const page = await browser.newPage();
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);
await page.setContent(` await page.setContent(`

3
tests/library/emulation-focus.spec.ts
View file

@ -104,7 +104,8 @@ it('should change document.activeElement', async ({ page, server }) => {
it('should not affect screenshots', async ({ page, server, browserName, headless, isWindows, channel }) => { it('should not affect screenshots', async ({ page, server, browserName, headless, isWindows, channel }) => {
it.skip(browserName === 'webkit' && isWindows && !headless, 'WebKit/Windows/headed has a larger minimal viewport. See https://github.com/microsoft/playwright/issues/22616'); it.skip(browserName === 'webkit' && isWindows && !headless, 'WebKit/Windows/headed has a larger minimal viewport. See https://github.com/microsoft/playwright/issues/22616');
it.skip(browserName === 'firefox' && !headless, 'Firefox headed produces a different image'); it.skip(browserName === 'firefox' && !headless, 'Firefox headed produces a different image');
it.fixme(browserName === 'chromium' && channel !== 'chromium-headless-shell', 'https://github.com/microsoft/playwright/issues/33330'); // TODO: We want to see test results
// it.fixme(browserName === 'chromium' && channel !== 'chromium-headless-shell', 'https://github.com/microsoft/playwright/issues/33330');
const page2 = await page.context().newPage(); const page2 = await page.context().newPage();
await Promise.all([ await Promise.all([

2
tests/library/permissions.spec.ts
View file

@ -156,7 +156,7 @@ it('should support clipboard read', async ({ page, context, server, browserName,
if (browserName !== 'webkit') if (browserName !== 'webkit')
expect(await getPermission(page, 'clipboard-read')).toBe('prompt'); expect(await getPermission(page, 'clipboard-read')).toBe('prompt');
if (browserName === 'chromium' && channel !== 'chromium-headless-shell') { if (browserName === 'chromium' && channel === 'chromium-headless-shell') {
// Chromium shows a dialog and does not resolve the promise. // Chromium shows a dialog and does not resolve the promise.
const error = await page.evaluate(() => navigator.clipboard.readText()).catch(e => e); const error = await page.evaluate(() => navigator.clipboard.readText()).catch(e => e);
expect(error.toString()).toContain('denied'); expect(error.toString()).toContain('denied');

3
tests/library/screenshot.spec.ts
View file

@ -23,7 +23,8 @@ browserTest.describe('page screenshot', () => {
browserTest.skip(({ browserName, headless }) => browserName === 'firefox' && !headless, 'Firefox headed produces a different image.'); browserTest.skip(({ browserName, headless }) => browserName === 'firefox' && !headless, 'Firefox headed produces a different image.');
browserTest('should run in parallel in multiple pages', async ({ server, contextFactory, browserName, channel }) => { browserTest('should run in parallel in multiple pages', async ({ server, contextFactory, browserName, channel }) => {
browserTest.fixme(browserName === 'chromium' && channel !== 'chromium-headless-shell', 'https://github.com/microsoft/playwright/issues/33330'); // TODO: We want to see test results
// browserTest.fixme(browserName === 'chromium' && channel !== 'chromium-headless-shell', 'https://github.com/microsoft/playwright/issues/33330');
const context = await contextFactory(); const context = await contextFactory();
const N = 5; const N = 5;
const pages = await Promise.all(Array(N).fill(0).map(async () => { const pages = await Promise.all(Array(N).fill(0).map(async () => {