Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: make the tree green (#21551)

Browse source 
References https://github.com/microsoft/playwright/issues/20522
References https://github.com/microsoft/playwright/issues/20993
References https://github.com/microsoft/playwright/issues/21435
References https://github.com/microsoft/playwright/issues/21512
References https://github.com/microsoft/playwright/issues/21549
References https://github.com/microsoft/playwright/issues/21550
This commit is contained in:
Andrey Lushnikov 2023-03-09 16:56:29 -08:00 committed by GitHub
parent a619ea4d68
commit 7a1c5b2aa3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 21 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
tests/electron/electron-app.spec.ts
View file

@ -48,7 +48,8 @@ test('should script application', async ({ electronApp }) => {
expect(appPath).toBe(path.resolve(__dirname)); expect(appPath).toBe(path.resolve(__dirname));
}); });
test('should preserve args', async ({ launchElectronApp }) => { test('should preserve args', async ({ launchElectronApp, isMac }) => {
test.fixme(isMac, 'https://github.com/microsoft/playwright/issues/21512');
const electronApp = await launchElectronApp('electron-app-args.js', ['foo', 'bar']); const electronApp = await launchElectronApp('electron-app-args.js', ['foo', 'bar']);
const argv = await electronApp.evaluate(async () => globalThis.argv); const argv = await electronApp.evaluate(async () => globalThis.argv);
expect(argv).toEqual([expect.stringContaining(path.join('dist', 'electron')), expect.stringContaining(path.join('electron', 'electron-app-args.js')), 'foo', 'bar']); expect(argv).toEqual([expect.stringContaining(path.join('dist', 'electron')), expect.stringContaining(path.join('electron', 'electron-app-args.js')), 'foo', 'bar']);

6
tests/library/capabilities.spec.ts
View file

@ -107,7 +107,8 @@ it('should play audio @smoke', async ({ page, server, browserName, platform }) =
expect(await page.$eval('audio', e => e.currentTime)).toBeGreaterThan(0.2); expect(await page.$eval('audio', e => e.currentTime)).toBeGreaterThan(0.2);
}); });
it('should support webgl @smoke', async ({ page, browserName, headless }) => { it('should support webgl @smoke', async ({ page, browserName, headless, browserMajorVersion, channel }) => {
it.fixme(channel === 'msedge' && browserMajorVersion === 111, 'https://github.com/microsoft/playwright/issues/21549');
const hasWebGL = await page.evaluate(() => { const hasWebGL = await page.evaluate(() => {
const canvas = document.createElement('canvas'); const canvas = document.createElement('canvas');
return !!canvas.getContext('webgl'); return !!canvas.getContext('webgl');
@ -115,7 +116,8 @@ it('should support webgl @smoke', async ({ page, browserName, headless }) => {
expect(hasWebGL).toBe(true); expect(hasWebGL).toBe(true);
}); });
it('should support webgl 2 @smoke', async ({ page, browserName, headless, isWindows }) => { it('should support webgl 2 @smoke', async ({ page, browserName, headless, isWindows, channel, browserMajorVersion }) => {
it.fixme(channel === 'msedge' && browserMajorVersion === 111, 'https://github.com/microsoft/playwright/issues/21549');
it.skip(browserName === 'webkit', 'WebKit doesn\'t have webgl2 enabled yet upstream.'); it.skip(browserName === 'webkit', 'WebKit doesn\'t have webgl2 enabled yet upstream.');
it.fixme(browserName === 'firefox' && isWindows); it.fixme(browserName === 'firefox' && isWindows);
it.fixme(browserName === 'chromium' && !headless, 'chromium doesn\'t like webgl2 when running under xvfb'); it.fixme(browserName === 'chromium' && !headless, 'chromium doesn\'t like webgl2 when running under xvfb');

9
tests/library/inspector/cli-codegen-2.spec.ts
View file

@ -104,7 +104,8 @@ test.describe('cli codegen', () => {
expect(errors.length).toBe(0); expect(errors.length).toBe(0);
}); });
test('should upload a single file', async ({ page, openRecorder, browserName, asset }) => { test('should upload a single file', async ({ page, openRecorder, browserName, asset, isLinux }) => {
test.fixme(browserName === 'firefox' && isLinux, 'https://github.com/microsoft/playwright/issues/21550');
const recorder = await openRecorder(); const recorder = await openRecorder();
await recorder.setContentAndWait(` await recorder.setContentAndWait(`
<form> <form>
@ -134,7 +135,8 @@ test.describe('cli codegen', () => {
await page.GetByRole(AriaRole.Textbox).SetInputFilesAsync(new[] { \"file-to-upload.txt\" });`); await page.GetByRole(AriaRole.Textbox).SetInputFilesAsync(new[] { \"file-to-upload.txt\" });`);
}); });
test('should upload multiple files', async ({ page, openRecorder, browserName, asset }) => { test('should upload multiple files', async ({ page, openRecorder, browserName, asset, isLinux }) => {
test.fixme(browserName === 'firefox' && isLinux, 'https://github.com/microsoft/playwright/issues/21550');
const recorder = await openRecorder(); const recorder = await openRecorder();
await recorder.setContentAndWait(` await recorder.setContentAndWait(`
<form> <form>
@ -164,7 +166,8 @@ test.describe('cli codegen', () => {
await page.GetByRole(AriaRole.Textbox).SetInputFilesAsync(new[] { \"file-to-upload.txt\", \"file-to-upload-2.txt\" });`); await page.GetByRole(AriaRole.Textbox).SetInputFilesAsync(new[] { \"file-to-upload.txt\", \"file-to-upload-2.txt\" });`);
}); });
test('should clear files', async ({ page, openRecorder, browserName, asset }) => { test('should clear files', async ({ page, openRecorder, browserName, asset, isLinux }) => {
test.fixme(browserName === 'firefox' && isLinux, 'https://github.com/microsoft/playwright/issues/21550');
const recorder = await openRecorder(); const recorder = await openRecorder();
await recorder.setContentAndWait(` await recorder.setContentAndWait(`
<form> <form>

2
tests/library/trace-viewer.spec.ts
View file

@ -25,6 +25,8 @@ const test = playwrightTest.extend<TraceViewerFixtures>(traceViewerFixtures);
test.skip(({ trace }) => trace === 'on'); test.skip(({ trace }) => trace === 'on');
test.slow(); test.slow();
test.fixme(({ mode }) => mode === 'service' || mode === 'driver', 'https://github.com/microsoft/playwright/issues/21435');
let traceFile: string; let traceFile: string;
test.beforeAll(async function recordTrace({ browser, browserName, browserType, server }, workerInfo) { test.beforeAll(async function recordTrace({ browser, browserName, browserType, server }, workerInfo) {

3
tests/library/video.spec.ts
View file

@ -512,7 +512,8 @@ it.describe('screencast', () => {
expect(videoPlayer.videoHeight).toBe(600); expect(videoPlayer.videoHeight).toBe(600);
}); });
it('should capture static page in persistent context @smoke', async ({ launchPersistent, browserName, trace }, testInfo) => { it('should capture static page in persistent context @smoke', async ({ launchPersistent, browserName, trace, isMac }, testInfo) => {
it.skip(browserName === 'webkit' && isMac && process.arch === 'arm64', 'Is only failing on self-hosted github actions runner on M1 mac; not reproducible locally');
const size = { width: 600, height: 400 }; const size = { width: 600, height: 400 };
const { context, page } = await launchPersistent({ const { context, page } = await launchPersistent({
recordVideo: { recordVideo: {

4
tests/page/page-click.spec.ts
View file

@ -159,7 +159,9 @@ it('should select the text by triple clicking', async ({ page, server }) => {
})).toBe(text); })).toBe(text);
}); });
it('should click offscreen buttons', async ({ page, server }) => { it('should click offscreen buttons', async ({ page, server, browserName, headless }) => {
it.fixme(!headless && browserName === 'firefox' && process.platform === 'darwin', 'https://github.com/microsoft/playwright/issues/20993');
await page.goto(server.PREFIX + '/offscreenbuttons.html'); await page.goto(server.PREFIX + '/offscreenbuttons.html');
const messages = []; const messages = [];
page.on('console', msg => messages.push(msg.text())); page.on('console', msg => messages.push(msg.text()));

3
tests/page/page-screenshot.spec.ts
View file

@ -277,7 +277,8 @@ it.describe('page screenshot', () => {
expect(screenshot).toMatchSnapshot('screenshot-canvas.png'); expect(screenshot).toMatchSnapshot('screenshot-canvas.png');
}); });
it('should capture canvas changes', async ({ page, isElectron, browserName, isMac, isWebView2 }) => { it('should capture canvas changes', async ({ page, isElectron, browserName, isMac, channel, browserMajorVersion, isWebView2 }) => {
it.fixme(browserName === 'firefox' && channel === 'firefox-beta' && browserMajorVersion === 110, 'https://github.com/microsoft/playwright/issues/20522');
it.fixme(browserName === 'webkit' && isMac, 'https://github.com/microsoft/playwright/issues/8796,https://github.com/microsoft/playwright/issues/16180'); it.fixme(browserName === 'webkit' && isMac, 'https://github.com/microsoft/playwright/issues/8796,https://github.com/microsoft/playwright/issues/16180');
it.skip(isElectron); it.skip(isElectron);
it.skip(isWebView2); it.skip(isWebView2);