Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: mark all crash tests as flaky on firefox win (#3675)

Browse source 
All crash tests do not actually crash sometimes on firefox win.
This commit is contained in:
Dmitry Gozman 2020-08-28 12:05:11 -07:00 committed by GitHub
parent 3d6051adb7
commit 7b1fac90bb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
test/page-event-crash.spec.ts
View file

@ -26,7 +26,7 @@ function crash(pageImpl, browserName) {
pageImpl._delegate._session.send('Page.crash', {}).catch(e => {}); pageImpl._delegate._session.send('Page.crash', {}).catch(e => {});
} }
it.fail(options.WIRE)('should emit crash event when page crashes', async ({page, browserName, toImpl}) => { it.fail(options.WIRE).flaky(options.FIREFOX && WIN)('should emit crash event when page crashes', async ({page, browserName, toImpl}) => {
await page.setContent(`<div>This page should crash</div>`); await page.setContent(`<div>This page should crash</div>`);
crash(toImpl(page), browserName); crash(toImpl(page), browserName);
await new Promise(f => page.on('crash', f)); await new Promise(f => page.on('crash', f));
@ -41,7 +41,7 @@ it.fail(options.WIRE).flaky(options.FIREFOX && WIN)('should throw on any action
expect(err.message).toContain('crash'); expect(err.message).toContain('crash');
}); });
it.fail(options.WIRE)('should cancel waitForEvent when page crashes', async ({page, browserName, toImpl}) => { it.fail(options.WIRE).flaky(options.FIREFOX && WIN)('should cancel waitForEvent when page crashes', async ({page, browserName, toImpl}) => {
await page.setContent(`<div>This page should crash</div>`); await page.setContent(`<div>This page should crash</div>`);
const promise = page.waitForEvent('response').catch(e => e); const promise = page.waitForEvent('response').catch(e => e);
crash(toImpl(page), browserName); crash(toImpl(page), browserName);
@ -49,7 +49,7 @@ it.fail(options.WIRE)('should cancel waitForEvent when page crashes', async ({pa
expect(error.message).toContain('Page crashed'); expect(error.message).toContain('Page crashed');
}); });
it.fixme(options.WIRE)('should cancel navigation when page crashes', async ({page, browserName, toImpl, server}) => { it.fixme(options.WIRE).flaky(options.FIREFOX && WIN)('should cancel navigation when page crashes', async ({page, browserName, toImpl, server}) => {
await page.setContent(`<div>This page should crash</div>`); await page.setContent(`<div>This page should crash</div>`);
server.setRoute('/one-style.css', () => {}); server.setRoute('/one-style.css', () => {});
const promise = page.goto(server.PREFIX + '/one-style.html').catch(e => e); const promise = page.goto(server.PREFIX + '/one-style.html').catch(e => e);