Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Revert "propagate --onlyChanged through UI"

Browse source 
This reverts commit bfe75e45f4bd7827788531e0756ed989b1d298f5.
This commit is contained in:
Simon Knott 2024-07-18 10:12:01 +02:00
parent 8de68512c6
commit 91ba44c46f
No known key found for this signature in database
GPG key ID: 8CEDC00028084AEC
5 changed files with 1 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/playwright-core/src/server/trace/viewer/traceViewer.ts
View file

@ -39,7 +39,6 @@ export type TraceViewerRedirectOptions = {
args?: string[]; args?: string[];
grep?: string; grep?: string;
grepInvert?: string; grepInvert?: string;
onlyChanged?: string;
project?: string[]; project?: string[];
workers?: number | string; workers?: number | string;
headed?: boolean; headed?: boolean;
@ -124,8 +123,6 @@ export async function installRootRedirect(server: HttpServer, traceUrls: string[
params.append('grep', options.grep); params.append('grep', options.grep);
if (options.grepInvert) if (options.grepInvert)
params.append('grepInvert', options.grepInvert); params.append('grepInvert', options.grepInvert);
if (options.onlyChanged)
params.append('onlyChanged', options.onlyChanged);
for (const project of options.project || []) for (const project of options.project || [])
params.append('project', project); params.append('project', project);
if (options.workers) if (options.workers)

1
packages/playwright/src/isomorphic/testServerInterface.ts
View file

@ -88,7 +88,6 @@ export interface TestServerInterface {
locations?: string[]; locations?: string[];
grep?: string; grep?: string;
grepInvert?: string; grepInvert?: string;
onlyChanged?: string;
testIds?: string[]; testIds?: string[];
headed?: boolean; headed?: boolean;
workers?: number | string; workers?: number | string;

3
packages/playwright/src/program.ts
View file

@ -164,7 +164,6 @@ async function runTests(args: string[], opts: { [key: string]: any }) {
args, args,
grep: opts.grep as string | undefined, grep: opts.grep as string | undefined,
grepInvert: opts.grepInvert as string | undefined, grepInvert: opts.grepInvert as string | undefined,
onlyChanged: opts.onlyChanged === true ? 'HEAD' : opts.onlyChanged,
project: opts.project || undefined, project: opts.project || undefined,
headed: opts.headed, headed: opts.headed,
reporter: Array.isArray(opts.reporter) ? opts.reporter : opts.reporter ? [opts.reporter] : undefined, reporter: Array.isArray(opts.reporter) ? opts.reporter : opts.reporter ? [opts.reporter] : undefined,
@ -192,7 +191,7 @@ async function runTests(args: string[], opts: { [key: string]: any }) {
config.cliArgs = args; config.cliArgs = args;
config.cliGrep = opts.grep as string | undefined; config.cliGrep = opts.grep as string | undefined;
config.cliOnlyChanged = getOnlyChangedArg(opts.onlyChanged); config.cliOnlyChanged = opts.onlyChanged === true ? 'HEAD' : opts.onlyChanged;
config.cliGrepInvert = opts.grepInvert as string | undefined; config.cliGrepInvert = opts.grepInvert as string | undefined;
config.cliListOnly = !!opts.list; config.cliListOnly = !!opts.list;
config.cliProjectFilter = opts.project || undefined; config.cliProjectFilter = opts.project || undefined;

1
packages/playwright/src/runner/testServer.ts
View file

@ -335,7 +335,6 @@ class TestServerDispatcher implements TestServerInterface {
config.cliArgs = params.locations || []; config.cliArgs = params.locations || [];
config.cliGrep = params.grep; config.cliGrep = params.grep;
config.cliGrepInvert = params.grepInvert; config.cliGrepInvert = params.grepInvert;
config.cliOnlyChanged = params.onlyChanged;
config.cliProjectFilter = params.projects?.length ? params.projects : undefined; config.cliProjectFilter = params.projects?.length ? params.projects : undefined;
config.testIdMatcher = testIdSet ? id => testIdSet.has(id) : undefined; config.testIdMatcher = testIdSet ? id => testIdSet.has(id) : undefined;

2
packages/trace-viewer/src/ui/uiModeView.tsx
View file

@ -56,7 +56,6 @@ const queryParams = {
args: searchParams.getAll('arg'), args: searchParams.getAll('arg'),
grep: searchParams.get('grep') || undefined, grep: searchParams.get('grep') || undefined,
grepInvert: searchParams.get('grepInvert') || undefined, grepInvert: searchParams.get('grepInvert') || undefined,
onlyChanged: searchParams.get('onlyChanged') || undefined,
projects: searchParams.getAll('project'), projects: searchParams.getAll('project'),
workers: searchParams.get('workers') || undefined, workers: searchParams.get('workers') || undefined,
timeout: searchParams.has('timeout') ? +searchParams.get('timeout')! : undefined, timeout: searchParams.has('timeout') ? +searchParams.get('timeout')! : undefined,
@ -283,7 +282,6 @@ export const UIModeView: React.FC<{}> = ({
locations: queryParams.args, locations: queryParams.args,
grep: queryParams.grep, grep: queryParams.grep,
grepInvert: queryParams.grepInvert, grepInvert: queryParams.grepInvert,
onlyChanged: queryParams.onlyChanged,
testIds: [...testIds], testIds: [...testIds],
projects: [...projectFilters].filter(([_, v]) => v).map(([p]) => p), projects: [...projectFilters].filter(([_, v]) => v).map(([p]) => p),
workers: queryParams.workers, workers: queryParams.workers,