Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse source 
Signed-off-by: Max Schmitt <max@schmitt.mx>
This commit is contained in:
Max Schmitt 2024-03-14 18:03:06 +01:00 committed by GitHub
parent 2a6754a005
commit 9ee8b8e2a9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
tests/page/page-set-input-files.spec.ts
View file

@ -37,7 +37,7 @@ it('should upload the file', async ({ page, server, asset }) => {
}, input)).toBe('contents of the file');
});
it('should upload the file with a popup which opened/closed before', async ({ page, server, asset, browserName }) => {
it('should upload the file after popup', async ({ page, server, asset, browserName }) => {
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/29923' });
it.fixme(browserName === 'firefox');
await page.goto(server.PREFIX + '/input/fileupload.html');
@ -47,7 +47,6 @@ it('should upload the file with a popup which opened/closed before', async ({ pa
page.evaluate(() => window['__popup'] = window.open('about:blank')),
]);
await popup.close();
await page.waitForTimeout(1000)
}
const filePath = path.relative(process.cwd(), asset('file-to-upload.txt'));
const input = await page.$('input');