Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(snapshot): remove integrity checksum for css (#3729)

Browse source 
Otherwise we cannot override css with cssom changes.
This commit is contained in:
Dmitry Gozman 2020-09-02 10:20:52 -07:00 committed by GitHub
parent a58812523c
commit a4563a85ce
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 22 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/server/snapshotterInjected.ts
View file

@ -168,6 +168,8 @@ export function takeSnapshotInFrame(guid: string, removeNoScript: boolean): Snap
continue; continue;
if (name === 'checked' || name === 'disabled' || name === 'checked') if (name === 'checked' || name === 'disabled' || name === 'checked')
continue; continue;
if (nodeName === 'LINK' && name === 'integrity')
continue;
if (name === 'src' && (nodeName === 'IFRAME' || nodeName === 'FRAME')) { if (name === 'src' && (nodeName === 'IFRAME' || nodeName === 'FRAME')) {
// TODO: handle srcdoc? // TODO: handle srcdoc?
let protocol = win.location.protocol; let protocol = win.location.protocol;

23
utils/showTestTraces.js
View file

@ -19,9 +19,26 @@ const fs = require('fs');
const playwright = require('..'); const playwright = require('..');
const { showTraceViewer } = require('../lib/trace/traceViewer'); const { showTraceViewer } = require('../lib/trace/traceViewer');
const testResultsDir = process.argv[2] || path.join(__dirname, '..', 'test-results'); if (process.argv.includes('--help')) {
const files = collectFiles(testResultsDir, ''); console.log(`Usage:`);
const traceStorageDir = path.join(testResultsDir, 'trace-storage'); console.log(` - npm run show-trace`);
console.log(` Show traces from the last test run.`);
console.log(` - npm run show-trace <test-results-directory>`);
console.log(` Show traces from the downloaded test results.`);
console.log(` - npm run show-trace <trace-file> <trace-storage-directory>`);
console.log(` Show single trace file from the manual run.`);
process.exit(0);
}
let traceStorageDir, files;
if (process.argv[3]) {
files = [process.argv[2]];
traceStorageDir = process.argv[3];
} else {
const testResultsDir = process.argv[2] || path.join(__dirname, '..', 'test-results');
files = collectFiles(testResultsDir, '');
traceStorageDir = path.join(testResultsDir, 'trace-storage');
}
console.log(`Found ${files.length} trace files`); console.log(`Found ${files.length} trace files`);
showTraceViewer(playwright, traceStorageDir, files); showTraceViewer(playwright, traceStorageDir, files);