Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

tests(webkit): mark Page.navigate to invalid URL test as passing

Browse source
This commit is contained in:
Yury Semikhatsky 2019-12-18 14:35:03 -08:00
parent 9afd35d3a1
commit a8119209fe
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
package.json
View file

@ -10,7 +10,7 @@
"playwright": {
"chromium_revision": "724623",
"firefox_revision": "1008",
"webkit_revision": "1044"
"webkit_revision": "1046"
},
"scripts": {
"unit": "node test/test.js",

3
test/navigation.spec.js
View file

@ -141,10 +141,9 @@ module.exports.addTests = function({testRunner, expect, playwright, FFOX, CHROME
const response = await page.goto(server.EMPTY_PAGE, {waitUntil: 'networkidle2'});
expect(response.status()).toBe(200);
});
it.skip(WEBKIT)('should fail when navigating to bad url', async({page, server}) => {
it('should fail when navigating to bad url', async({page, server}) => {
let error = null;
await page.goto('asdfasdf').catch(e => error = e);
// FIXME: shows dialog in WebKit.
if (CHROME || WEBKIT)
expect(error.message).toContain('Cannot navigate to invalid URL');
else