Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(tracing): store relative video path in the trace (#4710)

Browse source
This commit is contained in:
Dmitry Gozman 2020-12-14 13:31:55 -08:00 committed by GitHub
parent e91eee84d8
commit ab63063c03
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/trace/tracer.ts
View file

@ -77,10 +77,12 @@ class ContextTracer implements SnapshotterDelegate, ActionListener {
private _eventListeners: RegisteredListener[]; private _eventListeners: RegisteredListener[];
private _disposed = false; private _disposed = false;
private _pageToId = new Map<Page, string>(); private _pageToId = new Map<Page, string>();
private _traceFile: string;
constructor(context: BrowserContext, traceStorageDir: string, traceFile: string) { constructor(context: BrowserContext, traceStorageDir: string, traceFile: string) {
this._context = context; this._context = context;
this._contextId = 'context@' + createGuid(); this._contextId = 'context@' + createGuid();
this._traceFile = traceFile;
this._traceStoragePromise = mkdirIfNeeded(path.join(traceStorageDir, 'sha1')).then(() => traceStorageDir); this._traceStoragePromise = mkdirIfNeeded(path.join(traceStorageDir, 'sha1')).then(() => traceStorageDir);
this._appendEventChain = mkdirIfNeeded(traceFile).then(() => traceFile); this._appendEventChain = mkdirIfNeeded(traceFile).then(() => traceFile);
this._writeArtifactChain = Promise.resolve(); this._writeArtifactChain = Promise.resolve();
@ -162,7 +164,7 @@ class ContextTracer implements SnapshotterDelegate, ActionListener {
type: 'page-video', type: 'page-video',
contextId: this._contextId, contextId: this._contextId,
pageId, pageId,
fileName: path.basename(video._path), fileName: path.relative(path.dirname(this._traceFile), video._path),
}; };
this._appendTraceEvent(event); this._appendTraceEvent(event);
}); });