Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse source 
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
Signed-off-by: Max Schmitt <max@schmitt.mx>
This commit is contained in:
Max Schmitt 2024-07-18 15:50:24 +02:00 committed by GitHub
parent b07e5aa927
commit bd654db9c0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/trace-viewer/src/ui/timeline.tsx
View file

@ -29,7 +29,7 @@ import type { ConsoleEntry } from './consoleTab';
type TimelineBar = { type TimelineBar = {
action?: ActionTraceEventInContext; action?: ActionTraceEventInContext;
resource?: Entry; resource?: Entry;
consoleMessage?: ConsoleEntry consoleMessage?: ConsoleEntry;
leftPosition: number; leftPosition: number;
rightPosition: number; rightPosition: number;
leftTime: number; leftTime: number;
@ -116,7 +116,7 @@ export const Timeline: React.FunctionComponent<{
for (const bar of bars) { for (const bar of bars) {
if (highlightedAction) if (highlightedAction)
bar.active = bar.action === highlightedAction; bar.active = bar.action === highlightedAction;
if (highlightedEntry) else if (highlightedEntry)
bar.active = bar.resource === highlightedEntry; bar.active = bar.resource === highlightedEntry;
else if (highlightedConsoleEntry) else if (highlightedConsoleEntry)
bar.active = bar.consoleMessage === highlightedConsoleEntry; bar.active = bar.consoleMessage === highlightedConsoleEntry;