Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

use existing options.baseURL

Browse source
This commit is contained in:
Simon Knott 2024-07-25 12:30:52 +02:00
parent 418f5d2e81
commit c8f2d6bed6
No known key found for this signature in database
GPG key ID: 8CEDC00028084AEC
5 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
packages/playwright-core/src/server/trace/recorder/tracing.ts
View file

@ -109,7 +109,6 @@ export class Tracing extends SdkObject implements InstrumentationListener, Snaps
this._contextCreatedEvent.browserName = context._browser.options.name; this._contextCreatedEvent.browserName = context._browser.options.name;
this._contextCreatedEvent.channel = context._browser.options.channel; this._contextCreatedEvent.channel = context._browser.options.channel;
this._contextCreatedEvent.options = context._options; this._contextCreatedEvent.options = context._options;
this._contextCreatedEvent.baseURL = context._options.baseURL;
} }
} }

1
packages/trace-viewer/src/entries.ts
View file

@ -24,7 +24,6 @@ export type ContextEntry = {
startTime: number; startTime: number;
endTime: number; endTime: number;
browserName: string; browserName: string;
baseURL?: string;
channel?: string; channel?: string;
platform?: string; platform?: string;
wallTime: number; wallTime: number;

1
packages/trace-viewer/src/traceModernizer.ts
View file

@ -85,7 +85,6 @@ export class TraceModernizer {
this._version = event.version; this._version = event.version;
contextEntry.origin = event.origin; contextEntry.origin = event.origin;
contextEntry.browserName = event.browserName; contextEntry.browserName = event.browserName;
contextEntry.baseURL = event.baseURL;
contextEntry.channel = event.channel; contextEntry.channel = event.channel;
contextEntry.title = event.title; contextEntry.title = event.title;
contextEntry.platform = event.platform; contextEntry.platform = event.platform;

2
packages/trace-viewer/src/ui/modelUtil.ts
View file

@ -84,7 +84,7 @@ export class MultiTraceModel {
const libraryContext = contexts.find(context => context.origin === 'library'); const libraryContext = contexts.find(context => context.origin === 'library');
this.browserName = libraryContext?.browserName || ''; this.browserName = libraryContext?.browserName || '';
this.baseURL = libraryContext?.baseURL; this.baseURL = libraryContext?.options.baseURL;
this.sdkLanguage = libraryContext?.sdkLanguage; this.sdkLanguage = libraryContext?.sdkLanguage;
this.channel = libraryContext?.channel; this.channel = libraryContext?.channel;
this.testIdAttributeName = libraryContext?.testIdAttributeName; this.testIdAttributeName = libraryContext?.testIdAttributeName;

2
packages/trace/src/trace.ts
View file

@ -24,6 +24,7 @@ export type Size = { width: number, height: number };
export type VERSION = 7; export type VERSION = 7;
export type BrowserContextEventOptions = { export type BrowserContextEventOptions = {
baseURL?: string,
viewport?: Size, viewport?: Size,
deviceScaleFactor?: number, deviceScaleFactor?: number,
isMobile?: boolean, isMobile?: boolean,
@ -43,7 +44,6 @@ export type ContextCreatedTraceEvent = {
options: BrowserContextEventOptions, options: BrowserContextEventOptions,
sdkLanguage?: Language, sdkLanguage?: Language,
testIdAttributeName?: string, testIdAttributeName?: string,
baseURL?: string,
}; };
export type ScreencastFrameTraceEvent = { export type ScreencastFrameTraceEvent = {