Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore: remove redundant check for highlight liveness (#28108)

Browse source 
Closes https://github.com/microsoft/playwright/issues/28002
This commit is contained in:
Pavel Feldman 2023-11-13 11:44:25 -08:00 committed by GitHub
parent db38f0d2df
commit cd70d51aa8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/playwright-core/src/server/injected/highlight.ts
View file

@ -96,10 +96,6 @@ export class Highlight {
this._glassPaneElement.remove(); this._glassPaneElement.remove();
} }
isInstalled(): boolean {
return this._glassPaneElement.parentElement === this._injectedScript.document.documentElement && !this._glassPaneElement.nextElementSibling;
}
showActionPoint(x: number, y: number) { showActionPoint(x: number, y: number) {
this._actionPointElement.style.top = y + 'px'; this._actionPointElement.style.top = y + 'px';
this._actionPointElement.style.left = x + 'px'; this._actionPointElement.style.left = x + 'px';

3
packages/playwright-core/src/server/injected/recorder.ts
View file

@ -842,9 +842,6 @@ export class Recorder {
} }
installListeners() { installListeners() {
// Ensure we are attached to the current document, and we are on top (last element);
if (this.highlight.isInstalled())
return;
removeEventListeners(this._listeners); removeEventListeners(this._listeners);
this._listeners = [ this._listeners = [
addEventListener(this.document, 'click', event => this._onClick(event as MouseEvent), true), addEventListener(this.document, 'click', event => this._onClick(event as MouseEvent), true),