Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix linter

Browse source
This commit is contained in:
Max Schmitt 2024-11-11 18:12:26 +01:00
parent d1a9c64c0c
commit ce6efaa75e
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/playwright-core/src/client/page.ts
View file

@ -786,14 +786,14 @@ export class Page extends ChannelOwner<channels.PageChannel> implements api.Page
return [...this._workers]; return [...this._workers];
} }
async pause(options?: { __testHookKeepTestTimeout: boolean }) { async pause(_options?: { __testHookKeepTestTimeout: boolean }) {
if (require('inspector').url()) if (require('inspector').url())
return; return;
const defaultNavigationTimeout = this._browserContext._timeoutSettings.defaultNavigationTimeout(); const defaultNavigationTimeout = this._browserContext._timeoutSettings.defaultNavigationTimeout();
const defaultTimeout = this._browserContext._timeoutSettings.defaultTimeout(); const defaultTimeout = this._browserContext._timeoutSettings.defaultTimeout();
this._browserContext.setDefaultNavigationTimeout(0); this._browserContext.setDefaultNavigationTimeout(0);
this._browserContext.setDefaultTimeout(0); this._browserContext.setDefaultTimeout(0);
this._instrumentation?.onWillPause({ keepTestTimeout: !!options?.__testHookKeepTestTimeout }); this._instrumentation?.onWillPause({ keepTestTimeout: !!_options?.__testHookKeepTestTimeout });
await this._closedOrCrashedScope.safeRace(this.context()._channel.pause()); await this._closedOrCrashedScope.safeRace(this.context()._channel.pause());
this._browserContext.setDefaultNavigationTimeout(defaultNavigationTimeout); this._browserContext.setDefaultNavigationTimeout(defaultNavigationTimeout);
this._browserContext.setDefaultTimeout(defaultTimeout); this._browserContext.setDefaultTimeout(defaultTimeout);

4
utils/doclint/missingDocs.js
View file

@ -120,7 +120,7 @@ function listMethods(rootNames, apiFileName) {
function shouldSkipMethodByName(className, methodName) { function shouldSkipMethodByName(className, methodName) {
if (methodName.startsWith('_') || methodName === 'T' || methodName === 'toString') if (methodName.startsWith('_') || methodName === 'T' || methodName === 'toString')
return true; return true;
if (/** @type {any} */(EventEmitter).prototype.hasOwnProperty(methodName)) if (EventEmitter.prototype.hasOwnProperty(methodName))
return true; return true;
return false; return false;
} }
@ -141,7 +141,7 @@ function listMethods(rootNames, apiFileName) {
const memberType = checker.getTypeOfSymbolAtLocation(member, member.valueDeclaration); const memberType = checker.getTypeOfSymbolAtLocation(member, member.valueDeclaration);
const signature = signatureForType(memberType); const signature = signatureForType(memberType);
if (signature) if (signature)
methods.set(name, new Set(signature.parameters.map(p => p.escapedName))); methods.set(name, new Set(signature.parameters.filter(p => !p.escapedName.startsWith('_')).map(p => p.escapedName)));
else else
methods.set(name, new Set()); methods.set(name, new Set());
} }