more

docs/src/api/class-mockingproxyfactory.md

@@ -13,6 +13,6 @@ Creates a new instance of [MockingProxy].
 
 ### param: MockingProxyFactory.newProxy.port
 * since: v1.51
-- `port` <[int]>
+- `port` ?<[int]>
 
 Port to listen on.

packages/playwright-core/src/server/mockingProxy.ts

@@ -198,6 +198,14 @@ export class MockingProxy extends SdkObject implements RequestContext {
     else
       await route.continue({ isFallback: false });
   }
+
+  addRouteInFlight(route: Route): void {
+    // no-op, might be useful for warnings
+  }
+
+  removeRouteInFlight(route: Route): void {
+    // no-op, might be useful for warnings
+  }
 }
 
 function headersArray(req: Pick<http.IncomingMessage, 'headersDistinct'>): HeadersArray {

packages/playwright-core/src/server/network.ts

@@ -91,8 +91,8 @@ export function stripFragmentFromUrl(url: string): string {
 export interface RequestContext extends SdkObject {
   fetchRequest: APIRequestContext;
 
-  addRouteInFlight?(route: Route): void;
-  removeRouteInFlight?(route: Route): void;
+  addRouteInFlight(route: Route): void;
+  removeRouteInFlight(route: Route): void;
 }
 
 export class Request extends SdkObject {
@@ -261,7 +261,7 @@ export class Route extends SdkObject {
     super(request._frame || request._context, 'route');
     this._request = request;
     this._delegate = delegate;
-    this._request._context.addRouteInFlight?.(this);
+    this._request._context.addRouteInFlight(this);
   }
 
   request(): Request {
@@ -347,7 +347,7 @@ export class Route extends SdkObject {
   }
 
   private _endHandling() {
-    this._request._context.removeRouteInFlight?.(this);
+    this._request._context.removeRouteInFlight(this);
   }
 }
 

packages/playwright-core/types/types.d.ts

@@ -20379,7 +20379,7 @@ export interface MockingProxyFactory {
    * Creates a new instance of [MockingProxy](https://playwright.dev/docs/api/class-mockingproxy).
    * @param port Port to listen on.
    */
-  newProxy(port: number): Promise<MockingProxy>;
+  newProxy(port?: number): Promise<MockingProxy>;
 }
 
 /**