Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse source 
Co-authored-by: Yury Semikhatsky <yurys@chromium.org>
Signed-off-by: Simon Knott <info@simonknott.de>
This commit is contained in:
Simon Knott 2024-08-09 11:55:22 +02:00 committed by GitHub
parent 9a8aaa4bac
commit d786a27ed5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
docs/src/best-practices-js.md
View file

@ -261,7 +261,7 @@ npx playwright --version
Setup CI/CD and run your tests frequently. The more often you run your tests the better. Ideally you should run your tests on each commit and pull request. Playwright comes with a [GitHub actions workflow](/ci-intro.md) so that tests will run on CI for you with no setup required. Playwright can also be setup on the [CI environment](/ci.md) of your choice. Setup CI/CD and run your tests frequently. The more often you run your tests the better. Ideally you should run your tests on each commit and pull request. Playwright comes with a [GitHub actions workflow](/ci-intro.md) so that tests will run on CI for you with no setup required. Playwright can also be setup on the [CI environment](/ci.md) of your choice.
Use Linux when running your tests on CI as it is cheaper. Developers can use whatever environment when running locally but use linux on CI. Set up [Sharding](./test-sharding.md) to make CI faster. Use Linux when running your tests on CI as it is cheaper. Developers can use whatever environment when running locally but use linux on CI. Consider setting up [Sharding](./test-sharding.md) to make CI faster.
### Lint your tests ### Lint your tests

4
docs/src/ci.md
View file

@ -61,9 +61,9 @@ export default defineConfig({
## CI configurations ## CI configurations
### GitHub Actions The [Command line tools](./browsers#install-system-dependencies) can be used to install all operating system dependencies in CI.
The [Command line tools](./browsers#install-system-dependencies) can be used to install all operating system dependencies on GitHub Actions. ### GitHub Actions
#### On push/pull_request #### On push/pull_request
* langs: js * langs: js