Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(launch): default to non-zero launch timeout (#24440)

Browse source 
When not specified, launch timeout is 3 minutes, taken from the
`DEFAULT_LAUNCH_TIMEOUT` constant.
Also, use the default launch timeout for `electron.launch()` instead of
default regular timeout.
This commit is contained in:
Dmitry Gozman 2023-07-26 16:16:00 -07:00 committed by GitHub
parent c8b45aa844
commit e0cbb0882b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/playwright-core/src/server/electron/electron.ts
View file

@ -239,7 +239,7 @@ export class Electron extends SdkObject {
app = new ElectronApplication(this, browser, nodeConnection, launchedProcess); app = new ElectronApplication(this, browser, nodeConnection, launchedProcess);
await app.initialize(); await app.initialize();
return app; return app;
}, TimeoutSettings.timeout(options)); }, TimeoutSettings.launchTimeout(options));
} }
} }

1
packages/playwright-test/src/index.ts
View file

@ -94,7 +94,6 @@ const playwrightFixtures: Fixtures<TestFixtures, WorkerFixtures> = ({
_browserOptions: [async ({ playwright, headless, channel, launchOptions, connectOptions, _artifactsDir }, use) => { _browserOptions: [async ({ playwright, headless, channel, launchOptions, connectOptions, _artifactsDir }, use) => {
const options: LaunchOptions = { const options: LaunchOptions = {
handleSIGINT: false, handleSIGINT: false,
timeout: 0,
...launchOptions, ...launchOptions,
}; };
if (headless !== undefined) if (headless !== undefined)