Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: skip wss/https tests which were failing on transport mode (#8733)

Browse source
This commit is contained in:
Max Schmitt 2021-09-07 11:17:09 +02:00 committed by GitHub
parent a1f26976b0
commit e832038ea2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
tests/browsertype-connect.spec.ts
View file

@ -23,7 +23,8 @@ import WebSocket from 'ws';
test.slow(true, 'All connect tests are slow'); test.slow(true, 'All connect tests are slow');
test('should connect over wss', async ({browserType , startRemoteServer, httpsServer}) => { test('should connect over wss', async ({browserType , startRemoteServer, httpsServer, mode}) => {
test.skip(mode !== 'default'); // Out of process transport does not allow us to set env vars dynamically.
const remoteServer = await startRemoteServer(); const remoteServer = await startRemoteServer();
const oldValue = process.env['NODE_TLS_REJECT_UNAUTHORIZED']; const oldValue = process.env['NODE_TLS_REJECT_UNAUTHORIZED'];

3
tests/chromium/chromium.spec.ts
View file

@ -286,7 +286,8 @@ playwrightTest('should report all pages in an existing browser', async ({ browse
} }
}); });
playwrightTest('should connect via https', async ({ browserType, browserOptions, httpsServer }, testInfo) => { playwrightTest('should connect via https', async ({ browserType, browserOptions, httpsServer, mode }, testInfo) => {
test.skip(mode !== 'default'); // Out of process transport does not allow us to set env vars dynamically.
const port = 9339 + testInfo.workerIndex; const port = 9339 + testInfo.workerIndex;
const browserServer = await browserType.launch({ const browserServer = await browserType.launch({
...browserOptions, ...browserOptions,