Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: enable videos on tracing bots (#3930)

Browse source
This commit is contained in:
Dmitry Gozman 2020-09-24 04:38:01 -07:00 committed by GitHub
parent e15ac44ead
commit fe41bbd303
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.github/workflows/tests.yml vendored
View file

@ -207,7 +207,7 @@ jobs:
# XVFB-RUN merges both STDOUT and STDERR, whereas we need only STDERR # XVFB-RUN merges both STDOUT and STDERR, whereas we need only STDERR
# Wrap `npm run` in a subshell to redirect STDERR to file. # Wrap `npm run` in a subshell to redirect STDERR to file.
# Enable core dumps in the subshell. # Enable core dumps in the subshell.
- run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- bash -c "ulimit -c unlimited && npx test-runner test/ --jobs=1 --forbid-only --timeout=30000 --global-timeout=5400000 --retries=3 --reporter=dot,json" - run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- bash -c "ulimit -c unlimited && npx test-runner test/ --jobs=1 --forbid-only --timeout=60000 --global-timeout=5400000 --retries=3 --reporter=dot,json"
env: env:
BROWSER: ${{ matrix.browser }} BROWSER: ${{ matrix.browser }}
TRACING: true TRACING: true

4
test/playwright.fixtures.ts
View file

@ -278,9 +278,7 @@ defineTestFixture('context', async ({ browser, testOutputDir, testConfig }, runT
const contextOptions: BrowserContextOptions = { const contextOptions: BrowserContextOptions = {
relativeArtifactsPath: path.relative(testConfig.outputDir, testOutputDir), relativeArtifactsPath: path.relative(testConfig.outputDir, testOutputDir),
recordTrace: !!options.TRACING, recordTrace: !!options.TRACING,
// TODO: enable videos. Currently, long videos are slowly processed by Chromium recordVideos: !!options.TRACING,
// and (sometimes) Firefox, which causes test timeouts.
// recordVideos: !!options.TRACING,
}; };
const context = await browser.newContext(contextOptions); const context = await browser.newContext(contextOptions);
await runTest(context); await runTest(context);