Simon Knott
01c932f4bd
share step via globals.ts instead
2024-10-18 10:58:01 +02:00
Simon Knott
d0dfbba7b6
Revert "wire up matcher with parent step"
...
This reverts commit 1b8cd6dd5b .
2024-10-18 10:50:18 +02:00
Simon Knott
1b8cd6dd5b
wire up matcher with parent step
2024-10-18 10:16:42 +02:00
Simon Knott
5329341ef2
allow collecting attachments before completing step
2024-10-18 09:42:22 +02:00
Simon Knott
2d4d402297
make parent step ID explicit
2024-10-18 09:34:22 +02:00
Simon Knott
0e9eaf2134
fix test
2024-10-16 12:12:33 +02:00
Simon Knott
97c11e4940
move attachments into steps
2024-10-16 12:03:09 +02:00
Simon Knott
64ed6e724c
Revert "remove category"
...
This reverts commit e4786e0154 .
2024-10-16 12:01:17 +02:00
Simon Knott
e4786e0154
remove category
2024-10-16 10:59:18 +02:00
Simon Knott
9a9d789e9b
show in html reporter
2024-10-16 10:39:26 +02:00
Simon Knott
13d305b959
add attachments array
2024-10-16 09:17:06 +02:00
Simon Knott
606860d250
remove attachment steps for everything except explicit testInfo.attach()
2024-10-16 09:00:00 +02:00
Simon Knott
71be4b982c
Merge branch 'main' into html-reporter-attachments
2024-10-16 08:56:35 +02:00
Pavel Feldman
94321fef1c
chore: implement locator.ariaSnapshot ( #33125 )
2024-10-15 18:47:26 -07:00
Pavel Feldman
b92b855638
test: unflake ff debugger test ( #33124 )
2024-10-15 16:21:55 -07:00
Pavel Feldman
b421bd8b0d
chore: add a basic snapshot generator test ( #33123 )
2024-10-15 15:21:45 -07:00
Pavel Feldman
4b1fbde2ad
chore: generate match snapshot ( #33105 )
2024-10-15 13:38:55 -07:00
Pavel Feldman
23b1012c70
chore: fix ff test for codegen ( #33122 )
2024-10-15 13:34:08 -07:00
Anand M Cherian
d40425ea58
docs: update to "Matching one of the two alternative locators" section ( #33079 )
...
Signed-off-by: Anand M Cherian <63868951+Anand-M-Cherian@users.noreply.github.com>
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
2024-10-15 12:45:03 -07:00
Playwright Service
615f1dbd63
feat(chromium-tip-of-tree): roll to r1269 ( #33117 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-10-15 17:51:57 +02:00
Dmitry Gozman
59a50cf596
fix(chromium): disable PlzDedicatedWorker again ( #33110 )
2024-10-15 02:13:19 -07:00
Dmitry Gozman
17837e564d
fix(routeWebSocket): make sure ws url without trailing slash is supported ( #33095 )
2024-10-15 02:08:27 -07:00
Dmitry Gozman
8a275e5a5b
docs: improve docs for WebSocketRoute ( #33097 )
2024-10-15 02:07:03 -07:00
Pavel Feldman
2c05d294a8
chore: fix webkit visibility check in aria matcher ( #33102 )
2024-10-14 15:55:21 -07:00
Pavel Feldman
a38ff6e0d8
chore: experimental toMatchAriaSnapshot ( #33014 )
2024-10-14 14:07:19 -07:00
Pavel Feldman
6cfcbe0d6d
chore: fix codegen selector while debugging ( #33099 )
...
Fixes #33052
2024-10-14 14:04:24 -07:00
Dmitry Gozman
ecd147ce43
fix(test runner): when sharding with beforeAll, use shards total instead of workers ( #33083 )
...
Otherwise, we might split the `beforeAll`-grouped test group into
`workers` parts instead of `shard.total` parts as the user would expect.
Fixes #33077 .
2024-10-14 13:46:06 -07:00
Yury Semikhatsky
f8806d253d
chore(bidi): remove assertion from response dispatch ( #33100 )
...
After the context has been disposed we can't route any callbacks to it
because
it is not in the map, so the assertion doesn't make sense as it always
ends up in
the top level session.
Fixes the following error:
```
pw:browser <closing ws> Closing websocket due to failed onmessage callback. eventData={"type":"success","id":32,"result":{}} e=Assertion error Error: Assertion error
pw:browser at assert (/home/yurys/playwright/packages/playwright-core/src/utils/debug.ts:21:11)
pw:browser at BidiSession.dispatchMessage (/home/yurys/playwright/packages/playwright-core/src/server/bidi/bidiConnection.ts:229:13)
pw:browser at BidiConnection.call [as _dispatchMessage] (/home/yurys/playwright/packages/playwright-core/src/server/bidi/bidiConnection.ts:93:25)
```
2024-10-14 13:25:30 -07:00
Playwright Service
c7fbeddaf4
feat(webkit): roll to r2092 ( #33078 )
2024-10-14 22:21:49 +02:00
Simon Knott
a8df750a48
fix(har): account for reused sockets ( #33087 )
...
Closes https://github.com/microsoft/playwright/issues/32960
If the socket is reused, the connect and DNS timings are set to -1,
because that timing doesn't apply to the current request. The time
between request start and the socket being free is counted as `blocked`.
2024-10-14 17:22:29 +02:00
Max Schmitt
9fcf60464d
chore: various v1.48.0 roll fixes for .NET ( #33096 )
2024-10-14 16:32:11 +02:00
Remigiusz Dudek
4c2d62a881
feat(html-reporter): recognize video attachment by the contentType ( #33074 )
...
Closes https://github.com/microsoft/playwright/issues/33073 .
---------
Signed-off-by: Remigiusz Dudek <remigiusz_dudek@tlen.pl>
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
2024-10-14 05:16:19 -07:00
Fumiaki MATSUSHIMA
0a63427c77
fix(codegen): fix unselect issue ( #33076 )
2024-10-13 13:16:01 +02:00
Playwright Service
699f51b227
feat(webkit): roll to r2091 ( #33070 )
2024-10-11 17:18:06 -07:00
Playwright Service
e4b0d5e6dd
feat(chromium): roll to r1142 ( #33062 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-10-11 16:33:59 +02:00
Max Schmitt
87624c5434
Revert "fix(codegen): fix unselect issue ( #32127 )" ( #33065 )
...
This reverts commit 5121b19ac6 .
The tree is red and fixing seems non-trivial.
Closes https://github.com/microsoft/playwright/issues/33064
Closes https://github.com/microsoft/playwright/pull/33060
2024-10-11 16:33:17 +02:00
Yury Semikhatsky
b9cce598dd
fix(screenshot): show image diff inline in errors list ( #32997 )
...
The diff is now shown inline in the errors list.
There are 2 possible failures of toHaveScreenshot
* Previous and actual snapshot mismatch. In this case html report will
show diff between Actual/Previous and have Expected as a separate
screenshot.
* Actual/Previous are equal but they differ from the expected. In this
case html report only contains Actual/Expected images and the diff.
Reference: https://github.com/microsoft/playwright/issues/32341
<img width="1039" alt="image"
src="https://github.com/user-attachments/assets/b458f986-cc25-4721-862c-0cc2c1b01a42 ">
2024-10-10 16:49:17 -07:00
Playwright Service
10a9e1c730
feat(webkit): roll to r2090 ( #33050 )
2024-10-11 00:08:03 +02:00
Yury Semikhatsky
82fe882004
fix(webkit): scroll mobile page with background-attachment: fixed ( #33048 )
...
Fixes #31551
Fixes #23573
2024-10-10 14:32:27 -07:00
Playwright Service
7de084b6dc
feat(chromium-tip-of-tree): roll to r1268 ( #33042 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-10-10 16:32:00 +02:00
Playwright Service
217b57df4c
feat(webkit): roll to r2089 ( #33039 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-10-10 13:10:54 +02:00
Simon Knott
3472515669
fix test
2024-10-10 12:30:21 +02:00
Simon Knott
2cb9c525de
handle duplicate attachment names
2024-10-10 12:19:14 +02:00
Simon Knott
03082bdb0e
keep 0 margin as before
2024-10-10 12:12:33 +02:00
Simon Knott
6bc0848f0a
finish test
2024-10-10 11:59:38 +02:00
Simon Knott
e846370f77
params doesnt exist here
2024-10-10 11:45:10 +02:00
Simon Knott
cd76bb7d3e
test with html
2024-10-10 11:41:30 +02:00
Simon Knott
9f0965a0b2
proper depth
2024-10-10 11:41:19 +02:00
Simon Knott
ecb22691a1
proper html handling
2024-10-10 11:40:52 +02:00
Simon Knott
15c32f0679
result.attachments always exists
2024-10-10 11:12:57 +02:00