Simon Knott
6ec936f808
address most of the review
2024-07-23 11:02:48 +02:00
Simon Knott
ffc3f7fc99
revert some more unneeded changes
2024-07-23 11:02:48 +02:00
Simon Knott
ed43475de1
add trailing newline back in
2024-07-23 11:02:48 +02:00
Simon Knott
b1c04b1526
revert changes to DEPS
2024-07-23 11:02:47 +02:00
Simon Knott
193977b9fc
mention comment to upvote
2024-07-23 11:02:47 +02:00
Simon Knott
0b2a74e9ac
fix lint issues
2024-07-23 11:02:47 +02:00
Simon Knott
38a16c5738
remove windows crlf change and mark tests as slow
2024-07-23 11:02:47 +02:00
Simon Knott
eb19971298
ts fixes
2024-07-23 11:02:46 +02:00
Simon Knott
b9fe83071c
affectedTestFiles needs OS-specific paths
2024-07-23 11:02:46 +02:00
Simon Knott
1665d8ff60
tests still seem to pass without suite!
2024-07-23 11:02:46 +02:00
Simon Knott
8493789534
fix first windows tests
2024-07-23 11:02:27 +02:00
Simon Knott
f530806c93
try setting it locally
2024-07-23 11:02:27 +02:00
Simon Knott
226e00b61c
CRLF on windows
2024-07-23 11:02:26 +02:00
Simon Knott
2e6ed2f2c8
add note
2024-07-23 11:02:26 +02:00
Simon Knott
93983476f8
understand nested dependencies
2024-07-23 11:02:26 +02:00
Simon Knott
b618a613ea
fix it
2024-07-23 11:02:23 +02:00
Simon Knott
76e63c4bc6
refactor
2024-07-23 11:01:32 +02:00
Simon Knott
a11e7fb071
write down plan
2024-07-23 11:01:32 +02:00
Simon Knott
397b66d22a
fix typo
2024-07-23 11:01:32 +02:00
Simon Knott
fbcfdb5df2
show that component dependencies aren't yet understood
2024-07-23 11:01:31 +02:00
Simon Knott
5bdeb38a80
disallow --only-changed in UI mode
2024-07-23 11:01:31 +02:00
Simon Knott
6c19e0e38f
add CI recipe
2024-07-23 11:01:31 +02:00
Simon Knott
91ba44c46f
Revert "propagate --onlyChanged through UI"
...
This reverts commit bfe75e45f4bd7827788531e0756ed989b1d298f5.
2024-07-23 11:01:31 +02:00
Simon Knott
8de68512c6
Revert "add test"
...
This reverts commit 78c120c30a5834b565501a44ec81b487e6e51c23.
2024-07-23 11:01:30 +02:00
Simon Knott
a5d7ca17ae
remove CI smartypants
2024-07-23 11:01:30 +02:00
Simon Knott
6baf0b6009
add test
2024-07-23 11:01:30 +02:00
Simon Knott
7bb2780760
propagate --onlyChanged through UI
2024-07-23 11:01:29 +02:00
Simon Knott
2251e6a6d2
include onlyChanged in command hash
2024-07-23 11:01:29 +02:00
Simon Knott
ab05bbf9c8
untracked and tracked files need to be treated differently
2024-07-23 11:01:29 +02:00
Simon Knott
359edf9c0f
treat edge case of calling it in subdirectory
2024-07-23 11:01:29 +02:00
Simon Knott
0f38048ef2
fix DEPS
2024-07-23 11:01:28 +02:00
Simon Knott
f672d6dcf1
add test about component tests
2024-07-23 11:01:28 +02:00
Simon Knott
822c4cb2ad
remove BASE_REF in CI
2024-07-23 11:01:28 +02:00
Simon Knott
9fb7f13bfc
set local commit identity
2024-07-23 11:01:28 +02:00
Simon Knott
5d2da71fb8
also check CI env var
2024-07-23 11:01:27 +02:00
Simon Knott
ce788a6a1f
add docs
2024-07-23 11:01:27 +02:00
Simon Knott
5b758230d4
add nice error message
2024-07-23 11:01:27 +02:00
Simon Knott
5cb24de3ac
add test for watch mode
2024-07-23 11:01:26 +02:00
Simon Knott
0cbfd3470a
test more complex dependency graph
2024-07-23 11:01:26 +02:00
Simon Knott
bed44661e1
refactor
2024-07-23 11:01:26 +02:00
Simon Knott
72d7c86290
make it understand dependency structure
2024-07-23 11:01:26 +02:00
Simon Knott
824bea2aa0
refactor tests
2024-07-23 11:01:25 +02:00
Simon Knott
d907883518
detect base ref from environment variables
2024-07-23 11:01:25 +02:00
Simon Knott
2d9a299d66
allow comparison against base commit
2024-07-23 11:01:24 +02:00
Simon Knott
9123e1d9a1
extract method
2024-07-23 11:01:24 +02:00
Simon Knott
30447b14f4
support changed files
2024-07-23 11:01:24 +02:00
Simon Knott
da65da5d79
feat(test runner): --only-changed
2024-07-23 11:01:22 +02:00
Andrey Lushnikov
d23ea26947
feat(firefox): roll Firefox & Firefox-Beta to 1458 ( #31807 )
...
Fixes https://github.com/microsoft/playwright/issues/31525
Closes https://github.com/microsoft/playwright/pull/31806
Closes https://github.com/microsoft/playwright/pull/31805
2024-07-23 10:37:00 +02:00
Simon Knott
1408a45595
chore(ct): remove suite dependency by connecting dependency graphs at read time, not write time ( #31794 )
...
Broken out of https://github.com/microsoft/playwright/pull/31727 as per
@dgozman's
[request](https://github.com/microsoft/playwright/pull/31727#discussion_r1685793229 ).
The PR goal is to remove the `suite` argument from the Component
testing's Vite Plugin. `suite` is used to enrich Vite's dependency graph
with information about dependencies between test suites and helper
files. It essentially merges the Vite graph with the
`compilationCache.ts > fileDependencies` graph, and then writes the
result back into `compilationCache.ts > externalDependencies`.
By refactoring this to make the connection on the reading end in
`collectAffectedTestFiles`, we can drop the `suite` parameter.
We didn't yet have a test that depended on the dependency graph being
connected correctly between `fileDependencies` and
`externalDepedencies`, so I've [extended an existing
test](53a539938b
2024-07-23 10:19:58 +02:00
Pavel Feldman
cf1a313a0c
chore: allow empty string in regex patterns ( #31804 )
2024-07-22 13:02:12 -07:00
