Commit graph

12911 commits

Author SHA1 Message Date
Simon Knott eb19971298
ts fixes 2024-07-23 11:02:46 +02:00
Simon Knott b9fe83071c
affectedTestFiles needs OS-specific paths 2024-07-23 11:02:46 +02:00
Simon Knott 1665d8ff60
tests still seem to pass without suite! 2024-07-23 11:02:46 +02:00
Simon Knott 8493789534
fix first windows tests 2024-07-23 11:02:27 +02:00
Simon Knott f530806c93
try setting it locally 2024-07-23 11:02:27 +02:00
Simon Knott 226e00b61c
CRLF on windows 2024-07-23 11:02:26 +02:00
Simon Knott 2e6ed2f2c8
add note 2024-07-23 11:02:26 +02:00
Simon Knott 93983476f8
understand nested dependencies 2024-07-23 11:02:26 +02:00
Simon Knott b618a613ea
fix it 2024-07-23 11:02:23 +02:00
Simon Knott 76e63c4bc6
refactor 2024-07-23 11:01:32 +02:00
Simon Knott a11e7fb071
write down plan 2024-07-23 11:01:32 +02:00
Simon Knott 397b66d22a
fix typo 2024-07-23 11:01:32 +02:00
Simon Knott fbcfdb5df2
show that component dependencies aren't yet understood 2024-07-23 11:01:31 +02:00
Simon Knott 5bdeb38a80
disallow --only-changed in UI mode 2024-07-23 11:01:31 +02:00
Simon Knott 6c19e0e38f
add CI recipe 2024-07-23 11:01:31 +02:00
Simon Knott 91ba44c46f
Revert "propagate --onlyChanged through UI"
This reverts commit bfe75e45f4bd7827788531e0756ed989b1d298f5.
2024-07-23 11:01:31 +02:00
Simon Knott 8de68512c6
Revert "add test"
This reverts commit 78c120c30a5834b565501a44ec81b487e6e51c23.
2024-07-23 11:01:30 +02:00
Simon Knott a5d7ca17ae
remove CI smartypants 2024-07-23 11:01:30 +02:00
Simon Knott 6baf0b6009
add test 2024-07-23 11:01:30 +02:00
Simon Knott 7bb2780760
propagate --onlyChanged through UI 2024-07-23 11:01:29 +02:00
Simon Knott 2251e6a6d2
include onlyChanged in command hash 2024-07-23 11:01:29 +02:00
Simon Knott ab05bbf9c8
untracked and tracked files need to be treated differently 2024-07-23 11:01:29 +02:00
Simon Knott 359edf9c0f
treat edge case of calling it in subdirectory 2024-07-23 11:01:29 +02:00
Simon Knott 0f38048ef2
fix DEPS 2024-07-23 11:01:28 +02:00
Simon Knott f672d6dcf1
add test about component tests 2024-07-23 11:01:28 +02:00
Simon Knott 822c4cb2ad
remove BASE_REF in CI 2024-07-23 11:01:28 +02:00
Simon Knott 9fb7f13bfc
set local commit identity 2024-07-23 11:01:28 +02:00
Simon Knott 5d2da71fb8
also check CI env var 2024-07-23 11:01:27 +02:00
Simon Knott ce788a6a1f
add docs 2024-07-23 11:01:27 +02:00
Simon Knott 5b758230d4
add nice error message 2024-07-23 11:01:27 +02:00
Simon Knott 5cb24de3ac
add test for watch mode 2024-07-23 11:01:26 +02:00
Simon Knott 0cbfd3470a
test more complex dependency graph 2024-07-23 11:01:26 +02:00
Simon Knott bed44661e1
refactor 2024-07-23 11:01:26 +02:00
Simon Knott 72d7c86290
make it understand dependency structure 2024-07-23 11:01:26 +02:00
Simon Knott 824bea2aa0
refactor tests 2024-07-23 11:01:25 +02:00
Simon Knott d907883518
detect base ref from environment variables 2024-07-23 11:01:25 +02:00
Simon Knott 2d9a299d66
allow comparison against base commit 2024-07-23 11:01:24 +02:00
Simon Knott 9123e1d9a1
extract method 2024-07-23 11:01:24 +02:00
Simon Knott 30447b14f4
support changed files 2024-07-23 11:01:24 +02:00
Simon Knott da65da5d79
feat(test runner): --only-changed 2024-07-23 11:01:22 +02:00
Andrey Lushnikov d23ea26947
feat(firefox): roll Firefox & Firefox-Beta to 1458 (#31807)
Fixes https://github.com/microsoft/playwright/issues/31525
Closes https://github.com/microsoft/playwright/pull/31806
Closes https://github.com/microsoft/playwright/pull/31805
2024-07-23 10:37:00 +02:00
Simon Knott 1408a45595
chore(ct): remove suite dependency by connecting dependency graphs at read time, not write time (#31794)
Broken out of https://github.com/microsoft/playwright/pull/31727 as per
@dgozman's
[request](https://github.com/microsoft/playwright/pull/31727#discussion_r1685793229).

The PR goal is to remove the `suite` argument from the Component
testing's Vite Plugin. `suite` is used to enrich Vite's dependency graph
with information about dependencies between test suites and helper
files. It essentially merges the Vite graph with the
`compilationCache.ts > fileDependencies` graph, and then writes the
result back into `compilationCache.ts > externalDependencies`.

By refactoring this to make the connection on the reading end in
`collectAffectedTestFiles`, we can drop the `suite` parameter.

We didn't yet have a test that depended on the dependency graph being
connected correctly between `fileDependencies` and
`externalDepedencies`, so I've [extended an existing
test](53a539938b)
to capture that.
2024-07-23 10:19:58 +02:00
Pavel Feldman cf1a313a0c
chore: allow empty string in regex patterns (#31804) 2024-07-22 13:02:12 -07:00
Dmitry Gozman d87cb7a303
feat(trace viewer): allow hiding route actions (#31726)
Adds a new settings tab above the actions list.

<img width="307" alt="settings tab"
src="https://github.com/user-attachments/assets/792212b7-e2fd-4a5c-8878-654e2e060505">

Toggling the "Show route actions" checkbox hides all route calls:
`continue`, `fulfill`, `fallback`, `abort` and `fetch`.

References #30970.
2024-07-22 11:34:34 -07:00
Yury Semikhatsky e269092ef9
Revert "fix: add 'window-management' to chromium browser (#31687)" (#31801)
This reverts commit 0aa2f06f68.

Discussed the new permission in the API review and decided not to
proceed with the feature as we are not ready to commit to supporting it
yet:
* the API is Chromium specific
* the API is still experimental
* there is no clarity to what extend the screen manipulation APIs will
work in old headless which is our main test environment

We'll keep an eye on the demand for the feature and may get back to
implementing it in the future.

Reference: https://github.com/microsoft/playwright/issues/27198
2024-07-22 11:27:12 -07:00
Yury Semikhatsky bef87849e3
chore: show error when opening newer trace with old viewer (#31781)
Reference: https://github.com/microsoft/playwright-java/issues/1617
2024-07-22 08:16:25 -07:00
Josh Soref 7abbbd0c84
docs: spelling (#31779)
Fixes misspellings identified by the [check-spelling
action](https://github.com/marketplace/actions/check-spelling).

The misspellings have been reported at
https://github.com/jsoref/playwright/actions/runs/10015023629#summary-27685777352

The action will report that the changes in this PR would make it happy:
https://github.com/jsoref/playwright/actions/runs/10015023971#summary-27685778305

---

I understand that the commit messages will need to be reworded to match
house style. For the time being, these are merely noting the changes
they contain so that when I rebase or need to drop things, I can. --
I've already rebased once as someone fixed one of the items that my
draft work was going to fix.

---

## Testing
* The tests _mostly_ passed when I managed to trigger them, but there
were a handful of things that I didn't quite understand
* There are a large number of warnings relating to a bad interaction
between any workflow that uses this local action
b535139b32/.github/actions/run-test/action.yml (L74-L80)
and the action it calls -- I've opened Azure/login#474 asking them to
refactor their action so that it doesn't cause so much noise while
running this repository's tests
* I'm vaguely curious as to why this repository has a `branch`
constraint for its `pull_request` events in its workflows -- that
constraint gave me a number of additional headaches while trying to
prepare this branch for this PR.

---------

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2024-07-22 06:45:22 -07:00
Playwright Service af3d2ba9fe
feat(webkit): roll to r2048 (#31778)
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-07-20 14:27:41 +02:00
Dmitry Gozman b535139b32
fix(trace viewer): library-only trace should not merge actions (#31768)
Without `wallTime`, actions are matched by `actionName:undefined` and
all actions with the same are merged.

Fixes #31764.
2024-07-19 11:18:22 -07:00
Max Schmitt b8546eb35e
test: unflake client-certificate WebKit tests (#31776) 2024-07-19 15:08:04 +02:00