Commit graph

569 commits

Author SHA1 Message Date
Pavel Feldman a87426ee0d
Update bug.yml
Signed-off-by: Pavel Feldman <pavel.feldman@gmail.com>
2024-09-04 09:17:43 -07:00
dependabot[bot] b43915f4cc
chore(deps): bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows (#32436) 2024-09-04 13:05:51 +02:00
Max Schmitt cae779b74f
docs: recommend Ubuntu 24.04 in Docker images (#31435) 2024-08-12 16:39:56 +02:00
Max Schmitt 73e0e92a7e
devops: retry download of upstream Node.js for drivers (#31962) 2024-08-01 19:45:25 +02:00
Max Schmitt 335d31bf65
devops: remove GHA todo in primary workflow for itest (#31871)
This TODO got added during our GHA refactoring a while ago, where I
thought it might make sense to run our itests in `bash`. We didn't do it
before the refactoring either. It seems good to keep them running in
`pwsh` instead, so lets just remove the TODO.

Investigation notes: Running in `bash` on Windows via `Git Bash` seems
like doing a lot of magic, especially with path handling. Things
[like](a02ed38e60/tests/installation/registry.ts (L143))
this break then, since `tar` even when using `Git Bash` [doesn't accept
a Windows
path](https://sourceforge.net/p/mingw/mailman/mingw-users/thread/54CE104A.7060108@hccnet.nl/).

Signed-off-by: Max Schmitt <max@schmitt.mx>
2024-07-26 11:04:51 +02:00
Pavel Feldman 2a7f17d820
chore: fix simulated clock bots (#31301) 2024-06-17 09:17:38 -07:00
Max Schmitt 185cc43dbf
devops: fix merge reports on PRs (#31232) 2024-06-10 19:21:02 +02:00
Max Schmitt 9e6f051488
devops: merge other workflows (#31121) 2024-06-04 08:59:50 +02:00
Max Schmitt 8975684753
devops: group run-test commands into groups (#31116) 2024-06-03 16:39:18 +02:00
Max Schmitt 2c6fd722dd
feat: support Ubuntu 24.04 (#30826) 2024-06-03 12:47:16 +02:00
Pavel Feldman 8bfd0eb6e4
chore: introduce clock test mode (#31110) 2024-05-31 14:44:26 -07:00
Max Schmitt d6d373c459
devops: fix client side changes GHA workflow
Signed-off-by: Max Schmitt <max@schmitt.mx>
2024-05-30 18:56:03 +02:00
Max Schmitt 67181c9f11
devops: have client side changes issue per Playwright version (#31052)
This should address the issue which we had before of manually taking
entries over into a new issue.

Closes https://github.com/microsoft/playwright/pull/31027
2024-05-28 11:19:29 -07:00
Max Schmitt 3d7bd70aea
devops: bump actions/github-script@v6 to actions/github-script@v7 (#31028) 2024-05-28 18:10:53 +02:00
Max Schmitt 7057f28991
devops: migrate electron & video bots to re-usable run-test action (#30778) 2024-05-14 08:55:33 -07:00
Max Schmitt 8ef32a9394
devops: move microphone access into own action (#30634) 2024-05-08 20:03:37 +01:00
Max Schmitt 4adf184e5a
devops: remove Node.js 16 bots (#30683) 2024-05-06 22:52:31 +00:00
Max Schmitt c7e7a7ef56
devops: add Node.js 22 bots (#30644) 2024-05-06 19:58:44 +00:00
Max Schmitt a45617b4b5
devops: fix stress tests on Windows (#30655) 2024-05-03 18:05:52 +00:00
Max Schmitt 980f9c6ad4
chore: drop firefox-asan (#30626) 2024-05-01 22:13:00 +00:00
Max Schmitt 8a91ef1f55
devops: refactor GitHub Actions workflows (#30524) 2024-05-01 18:44:15 +00:00
Dmitry Gozman 086ea79c25
chore: remove checkCoverage script (#30552)
We do not benefit from it for many years already.
2024-04-25 14:00:14 -07:00
Max Schmitt c9e4c49c2f
devops: remove redundant files (#30521) 2024-04-24 22:26:31 +02:00
Max Schmitt 058a30877d
devops: fix headed macOS-14 bots (#30442) 2024-04-20 00:32:48 +02:00
Max Schmitt 629829816b
chore: move azure/login step to the end of the workflows (#30441) 2024-04-19 22:00:13 +02:00
Max Schmitt 3f8bd5ffd1
devops: updated auth mode follow-ups (#30440) 2024-04-19 21:23:39 +02:00
Max Schmitt ed0e1909e5
devops: change auth mode for flakiness/docker/driver uploads (#30405) 2024-04-19 20:36:15 +02:00
Stephen Wade fb3bcc8b18
devops: fix issues with audio in macOS 14 on GitHub Actions (#30410) 2024-04-18 20:07:39 +02:00
Max Schmitt 563c9baf00 devops: migrate html merge upload to Azure Federate credentials 2024-04-16 13:16:40 +02:00
Max Schmitt 47a7a3af90 devops: fix 'bump driver Node.js' workflow 2024-04-09 12:35:13 +02:00
Max Schmitt 14cd7953f3
devops(merge): validate zip before uploading (#30061) 2024-03-22 21:22:19 +01:00
Max Schmitt 4a67437704
devops(gha): move from always() to !cancelled() (#30060)
**Investigation:**

- According to
[here](https://github.com/microsoft/playwright/actions/runs/8351676198),
the job got cancelled, because someone force-pushed and another commit
took priority.
- We have `if: always()` for uploading the blobs, even if they are
cancelled. We expect, that the task before (`npx playwright test`)
finished writing the blob, but it didn't - cancelled in between. We
still upload - a broken one.
- We download the broken zip and it breaks from there on.

Proposed change: Instead of uploading always, upload if it did not get
cancelled.

Quoting from the GitHub Actions docs about `always()`:

> Warning: Avoid using always for any task that could suffer from a
critical failure, for example: getting sources, otherwise the workflow
may hang until it times out. If you want to run a job or step regardless
of its success or failure, use the recommended alternative: if: `${{
!cancelled() }}`

This is phase 1/2 where it changes our code to use this new condition.
The actual roll-out happens once it works for us.

Relates https://github.com/microsoft/playwright/issues/29451
2024-03-22 19:25:13 +01:00
Max Schmitt 911fd204cf
devops: fix WebView2 tests (#30009)
Turns out we were using version 119.0.2151.58 before where the tests are
failing. After this change we are using 122.0.2365.92.

Fixes https://github.com/microsoft/playwright/issues/29695
Relates https://github.com/actions/runner-images/issues/9538
2024-03-19 23:18:20 +01:00
Max Schmitt ef0a24a1b0
chore: remove chromium-with-symbols build (#29807) 2024-03-04 20:12:01 +01:00
Pavel Feldman ef924c14e7
chore: do not use project id in telereporter (#29776) 2024-03-01 21:44:08 -08:00
Max Schmitt 713fbb5d23
devops: fix cherry_pick_into_release_branch permissions (#29689)
Fixes
https://github.com/microsoft/playwright/actions/runs/8067553095/job/22038251156.

Signed-off-by: Max Schmitt <max@schmitt.mx>
2024-02-27 17:34:16 +01:00
Yury Semikhatsky 56028269bb
devops: add a hint how to create a repro (#29665)
Fixes https://github.com/microsoft/playwright/issues/29620
2024-02-26 13:33:57 -08:00
Max Schmitt fb48bfcbe6 Revert "devops: auto close questions (#29513)"
This reverts commit 09d0a099a2.
2024-02-15 19:22:25 +01:00
Max Schmitt 09d0a099a2
devops: auto close questions (#29513)
Signed-off-by: Max Schmitt <max@schmitt.mx>
2024-02-15 18:14:51 +01:00
Max Schmitt abd8502490
devops: do not publish sha-X Docker images (#29433) 2024-02-09 09:07:10 -08:00
Max Schmitt bf31f2865f
chore: disable blank issue templates (#29368) 2024-02-05 20:02:15 +01:00
Pavel Feldman 85e4589a90
Update feature.yml
Signed-off-by: Pavel Feldman <pavel.feldman@gmail.com>
2024-02-02 10:33:59 -08:00
Max Schmitt e69f159f43
devops: fix roll into PR action (#29318)
Signed-off-by: Max Schmitt <max@schmitt.mx>
2024-02-02 14:16:56 +01:00
Pavel Feldman d56a50245b
chore: Jest-inspired GitHub templates (thanks Jest!) (#29303) 2024-02-01 14:58:33 -08:00
Max Schmitt 4affcdef71
devops: run tests on macOS 14 (#29241) 2024-01-30 18:04:35 +01:00
Max Schmitt 1db4e2effb
devops: bump GitHub Actions workflow actions (#29219)
Fixes:

<img width="2186" alt="image"
src="https://github.com/microsoft/playwright/assets/17984549/e75b4319-a8d9-4784-8357-83611f2671ae">
2024-01-29 19:22:44 +01:00
Yury Semikhatsky 85c42939b1
devops: do not use broken overwrite: true for uploads (#29160)
Reverting parts of https://github.com/microsoft/playwright/pull/29080
related to use of overwrite: true as it is racy and
[fails](https://github.com/microsoft/playwright/actions/runs/7641699534/job/20819588957?pr=28932#step:10:63)
time to time with parallel jobs:


![image](https://github.com/microsoft/playwright/assets/9798949/cd484e2d-2875-4950-9247-5ea033c6e92d)


Reference https://github.com/actions/upload-artifact/issues/506
2024-01-25 12:55:29 -08:00
Yury Semikhatsky 4b0e55abda
devops: make sure uploaded reports always contain directory (#29080)
* Before the change if if uploaded artifact path contained just one file
it would be [archived
directly](694cdabd8b/src/search.ts (L142-L151)),
but if there is a sister folder it would be an archive of the entire
dir. According to the action docs "If a wildcard pattern is used, the
path hierarchy will be preserved after the first wildcard pattern", so
hopefully it means that the directory is always compressed even if there
is a single file in it.
* Use `overwrite: true` to have only one artifact with pull request
number.
2024-01-19 17:23:22 -08:00
Yury Semikhatsky a3c38bc1f9
devops: merge paginated results when downloading blobs (#29013)
* The results are paginated by default to return max 30 entries, see
[this
page](https://docs.github.com/en/rest/actions/workflow-runs?apiVersion=2022-11-28).
We use
[octakit.paginate](https://octokit.github.io/rest.js/v20#pagination),
wrapped into
[github-script](60a0d83039)
to automatically load all artifacts urls.

* Also bumped github-script to v7
2024-01-16 16:14:38 -08:00
Max Schmitt 67478efe92
devops: fix Chromium ToT headed tests (#28892)
This broke in
6c2c777cae (diff-2d067b4a60c6de032d0719122683d3179baf5c9ff0f1669ce8e05938102526e2L358)
2024-01-08 09:30:40 -08:00